Implement supportsPartial field
#649
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This lets us distinguish who can support a partial message request versus who requests partial message on a per topic basis.
Creates a mixed network where only one peer request partial, and the rest either support or don't
MarcoPolo
force-pushed
the
supports-partial
branch
from
ca702b7 to
a306e04
Compare
MarcoPolo
force-pushed
the
marco/partial-messages-2
branch
from
34e9bba to
d0f9caf
Compare
sukunrt
approved these changes
Oct 31, 2025
Comment on lines
+1583
to
+1584
| func SupportsPartialMessages() TopicOpt { | ||
| return func(t *Topic) error { |
There was a problem hiding this comment.
Can you add some documentation for this?
Comment on lines
+17
to
+19
| // messages on this topic. If requestsPartial is true, this is assumed to be | ||
| // true. | ||
| optional bool supportsPartial = 4; |
There was a problem hiding this comment.
NIT:
Suggested change
| // messages on this topic. If requestsPartial is true, this is assumed to be | |
| // true. | |
| optional bool supportsPartial = 4; | |
| // messages on this topic. If requestsPartial is true, this is assumed to be | |
| // true. | |
| optional bool supportsSendingPartial = 4; |
I think more explicit is more readable. requestsPartial has a receive connotation to it.
| tmap[rpc.from] = peerTopicState{requestsPartial: subopt.GetPartial()} | ||
| pts := peerTopicState{ | ||
| requestsPartial: subopt.GetRequestsPartial(), | ||
| // If they peer requested partial, they support it by default |
There was a problem hiding this comment.
NIT:
Suggested change
| // If they peer requested partial, they support it by default | |
| // If the peer requested partial, they support it by default |
Comment on lines
+1398
to
+1399
| return ok && gs.extensions.myExtensions.PartialMessages && peerStates[p].requestsPartial | ||
| } |
There was a problem hiding this comment.
Suggested change
| return ok && gs.extensions.myExtensions.PartialMessages && peerStates[p].requestsPartial | |
| } | |
| return ok && gs.extensions.myExtensions.PartialMessages && peerStates[p].supportsPartial | |
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lets us distinguish who can support a partial message request versus who requests partial message on a per topic basis.
See this spec commit for details: libp2p/specs@b90b21b