Skip to content

Conversation

@oblique
Copy link
Contributor

@oblique oblique commented Nov 3, 2025

Description

This removes a debug_assert from poll_flush because it can be valid for the user to recheck the flush state. In that case the operation should be noop.

A real life code that triggers this assertition is this.

Fixes #5618

Notes & open questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

@oblique oblique changed the title fix(webtransport-websys): Remove poll_flush called after poll_close assertion fix(webtransport-websys): Allow poll_flush after poll_close Nov 3, 2025
@oblique oblique changed the title fix(webtransport-websys): Allow poll_flush after poll_close fix(webtransport-websys): Allow poll_flush after poll_close Nov 3, 2025
Copy link
Member

@jxs jxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Yiannis how are you? Thanks for this, do you need a release?

@jxs jxs added the send-it label Nov 12, 2025
@mergify mergify bot added the queued label Nov 12, 2025
@mergify mergify bot merged commit ac1404e into libp2p:master Nov 12, 2025
69 of 70 checks passed
@mergify mergify bot removed the queued label Nov 12, 2025
@oblique
Copy link
Contributor Author

oblique commented Nov 13, 2025

Hi. I'm good. What about you? A release would be nice

@oblique oblique deleted the fix/poll-flush-after-poll-close branch November 13, 2025 11:39
@jxs
Copy link
Member

jxs commented Nov 14, 2025

also fine thanks! libp2p-webtransport-websys 0.5.2 has been published and tag created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Closed stream is polled causing debug assertion to fail for WebTransport in wasm

2 participants