Report pan value '---' for samples with no default panning. #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sezero
approved these changes
Nov 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes xmp handling of sample default panning values of -1 (no sample default panning). This was technically broken prior to libxmp/libxmp#904 for Impulse Tracker modules, but this patch made it affect most other formats too.
(This may set off some string.h warnings, particularly for macOS, which is petty about
strcpyeven when used correctly—we need better CI here.)To verify this works, you can play libxmp/test-dev/data/gal4_smpl_setpan.j2b and press the info keys
i(Instruments and Samples) andI(Instruments). The first sample should be left (P00), the second center (P80), the third right (Pff), and the last has no default panning (---).