Skip to content

Conversation

@jgryffindor
Copy link

Adding ExpandCode component to display truncated values and improve the display.
This mitigates an issue with the left sidebar nav background being duplicated (see before screenshot).

Description

  • Updating kvstore values to use ExpandCode component and truncate to display 5KB with larger values.
  • Wrapping kvstore data table in a box to set to 90% viewport height and introduce a scrollable box.

Fixes # (issue)

Testing

  • Tested locally against QA data with large values

Breaking Changes (if applicable)

None

Screenshots (if applicable)

Before:
image

After:
image

Checklist:

  • I have read and followed the CONTRIBUTING guidelines for this project.
  • I have added or updated tests and they pass.
  • I have added or updated documentation and it is accurate.
  • I have noted any breaking changes in this module or downstream modules.

Updating kvstore values to use ExpandCode component and truncate to display 5KB with larger values.
Wrapping kvstore data table in box to set to 90% viewport height and introduce a scrollable box.
This mitigates an issue with the left sidebar nav background being duplicated.
@netlify
Copy link

netlify bot commented Sep 12, 2023

Deploy Preview for lifted-gwen ready!

Name Link
🔨 Latest commit d0d5887
🔍 Latest deploy log https://app.netlify.com/sites/lifted-gwen/deploys/6500db648855e800087d941b
😎 Deploy Preview https://deploy-preview-74--lifted-gwen.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Merging #74 (d0d5887) into main (26510c9) will decrease coverage by 0.37%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main      #74      +/-   ##
==========================================
- Coverage   29.15%   28.78%   -0.37%     
==========================================
  Files          61       62       +1     
  Lines        1012     1025      +13     
  Branches      208      214       +6     
==========================================
  Hits          295      295              
- Misses        714      727      +13     
  Partials        3        3              
Files Changed Coverage Δ
src/pages/services/data/data-row.tsx 0.00% <ø> (ø)
src/pages/services/data/data-table.tsx 0.00% <ø> (ø)
src/shared/expand-code.tsx 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant