-
Notifications
You must be signed in to change notification settings - Fork 58
Add greenlet dependency for async SQLAlchemy operations #766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
greenlet is required by SQLAlchemy for async database operations with SQLite. Without it, llama-stack server fails to start when initializing SQLite-backed stores (files, agents, vector_io, etc.) using async context managers.
WalkthroughAdded greenlet>=3.0.0 dependency to pyproject.toml to support SQLAlchemy async operations. This is a single-line dependency addition with no other functional modifications. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Hi @anik120. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
pyproject.toml (1)
49-50: Consider updating to greenlet>=3.1.0 for Python 3.13 support.Python 3.13 support was added to greenlet in version 3.1.0 (Sept 2024), but the current constraint allows greenlet>=3.0.0, which would permit greenlet 3.0.x versions that lack Python 3.13 support. Since the project supports Python 3.12-3.13 (line 21), updating the constraint to
greenlet>=3.1.0would ensure compatibility across the full Python version range.Apply this diff to ensure Python 3.13 compatibility:
# Required by SQLAlchemy for async operations - "greenlet>=3.0.0", + "greenlet>=3.1.0",
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
uv.lockis excluded by!**/*.lock
📒 Files selected for processing (1)
pyproject.toml(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
pyproject.toml
📄 CodeRabbit inference engine (CLAUDE.md)
pyproject.toml: ALWAYS check pyproject.toml for existing dependencies before adding new ones
ALWAYS verify current library versions in pyproject.toml rather than assuming versions
Prefer reading supported Python versions and tool configs from pyproject.toml
Files:
pyproject.toml
🧠 Learnings (2)
📚 Learning: 2025-09-18T16:46:33.353Z
Learnt from: CR
Repo: lightspeed-core/lightspeed-stack PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-09-18T16:46:33.353Z
Learning: Applies to pyproject.toml : ALWAYS check pyproject.toml for existing dependencies before adding new ones
Applied to files:
pyproject.toml
📚 Learning: 2025-08-18T10:58:14.951Z
Learnt from: matysek
Repo: lightspeed-core/lightspeed-stack PR: 292
File: pyproject.toml:47-47
Timestamp: 2025-08-18T10:58:14.951Z
Learning: psycopg2-binary is required by some llama-stack providers in the lightspeed-stack project, so it cannot be replaced with psycopg v3 or moved to optional dependencies without breaking llama-stack functionality.
Applied to files:
pyproject.toml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: e2e_tests (ci)
- GitHub Check: e2e_tests (azure)
|
/ok-to-test |
|
@anik120 According to the SQLAlchemy docs and other resources, using |
Description
greenlet is required by SQLAlchemy for async database operations with SQLite. Without it, llama-stack server fails to start when initializing SQLite-backed stores (files, agents, vector_io, etc.) using async context managers.
Type of change
Related Tickets & Documents
Checklist before requesting a review
Testing
Summary by CodeRabbit