Skip to content

Conversation

@hombit
Copy link
Collaborator

@hombit hombit commented Sep 27, 2025

This should fix annoying bugs appeared in places like pack_lists, when input list arrays are "aligned" by list lengths (e.g. both lists are [2, 3, 1]), but not by offsets (e.g. one offset is [0, 2, 5, 6], another is [10, 12, 15, 16]).

@hombit hombit requested a review from dougbrn September 27, 2025 22:06
@codecov
Copy link

codecov bot commented Sep 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.26%. Comparing base (f592cac) to head (c11adc6).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #371      +/-   ##
==========================================
+ Coverage   98.19%   98.26%   +0.07%     
==========================================
  Files          19       19              
  Lines        1880     1906      +26     
==========================================
+ Hits         1846     1873      +27     
+ Misses         34       33       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link

github-actions bot commented Sep 27, 2025

Before [f592cac] After [29bbdfa] Ratio Benchmark (Parameter)
11.1±0.2ms 12.2±0.2ms 1.1 benchmarks.NestedFrameAddNested.time_run
172M 173M 1.01 benchmarks.ReadFewColumnsHTTPS.peakmem_run
43.6±2ms 44.2±0.1ms 1.01 benchmarks.ReassignHalfOfNestedSeries.time_run
250M 250M 1 benchmarks.AssignSingleDfToNestedSeries.peakmem_run
64.0±0.2ms 64.0±0.2ms 1 benchmarks.CountNestedBy.time_run
2.70±0.03s 2.70±0.03s 1 benchmarks.ReadFewColumnsHTTPS.time_run
1.80±0.01s 1.81±0.01s 1 benchmarks.ReadFewColumnsS3.time_run
270M 269M 1 benchmarks.ReassignHalfOfNestedSeries.peakmem_run
32.2±0.7ms 31.9±0.7ms 0.99 benchmarks.AssignSingleDfToNestedSeries.time_run
136M 135M 0.99 benchmarks.CountNestedBy.peakmem_run

Click here to view all benchmarks.

Copy link
Collaborator

@dougbrn dougbrn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hombit hombit merged commit cb5b36d into main Sep 29, 2025
12 checks passed
@hombit hombit deleted the allign-offsets branch September 29, 2025 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants