refactor: extract URLSearchParams creation to reusable helper #1477
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add createURLSearchParams helper function in utils.ts - Replace duplicate for...in loops with helper in http-axios.ts and http-fetch.ts - Improve type safety from 'any' to 'Record<string, unknown>' - Filter null/undefined values consistently across all HTTP methods This reduces code duplication and improves maintainability while ensuring consistent behavior for URL parameter handling.
|
|
Add comprehensive unit tests for createURLSearchParams function to verify: - Basic string value handling - Type conversion (numbers, booleans) - Null/undefined filtering - Edge cases (empty object, mixed types) This ensures the helper function works correctly in isolation and follows the existing testing pattern for utility functions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
createURLSearchParamshelper function inutils.tsfor...inloops with helper inhttp-axios.tsandhttp-fetch.tsanytoRecord<string, unknown>This reduces code duplication and improves maintainability while ensuring consistent behavior for URL parameter handling.