Add method to convert non-shared Collection/SourceCache to shared variants#541
Open
nicoburns wants to merge 1 commit intolinebender:mainfrom
Open
Add method to convert non-shared Collection/SourceCache to shared variants#541nicoburns wants to merge 1 commit intolinebender:mainfrom
Collection/SourceCache to shared variants#541nicoburns wants to merge 1 commit intolinebender:mainfrom
Conversation
nicoburns
force-pushed
the
make-shared
branch
3 times, most recently
from
5795bf4 to
3bbf724
Compare
Signed-off-by: Nico Burns <nico@nicoburns.com>
nicoburns
force-pushed
the
make-shared
branch
from
3bbf724 to
327b128
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows for opting in to sharing after construction. Which is useful when accepting an existing
FontContext/Collection/SourceCachewhich you then want to "fan out" into thread-local shared clones.Blitz is using the method on
SourceCache, but is using non-sharedCollections. But both methods are included in this PR for symmetry.