Add support for alternative bracket delimiters { } and [ ] (closes #143) #167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding CLAUDE.md with task information for AI processing. This file will be removed when the task is complete. Issue: #143
This PR implements issue #143 by adding support for curly braces `{ }` and square brackets `[ ]` as equivalent delimiters to parentheses `( )` for multiline links in all parser implementations. Changes: - JavaScript (Peggy grammar): Updated multiLineLink and multiLineValueLink rules to accept all three bracket types - Python: Modified parser to handle all bracket types in _parse_line_content, _split_lines_respecting_quotes, _find_colon_outside_quotes, _parse_values, and _parse_value functions - Rust (nom parser): Added open_bracket and close_bracket combinators for multiline link parsing - C# (PEG grammar): Added openBracket and closeBracket rules All implementations also update the referenceSymbol patterns to exclude the new bracket characters from unquoted references. Version bumped to 0.13.0 across all implementations. Closes #143 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
konard
changed the title
This reverts commit 736f9c4.
Member
Author
🤖 Solution Draft LogThis log file contains the complete execution trace of the AI solution draft process. 💰 Cost estimation:
Now working session is ended, feel free to review and add any feedback on the solution draft. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements issue #143 by adding support for curly braces
{ }and square brackets[ ]as equivalent delimiters to parentheses( )for multiline links in all parser implementations.Changes by language:
multiLineLinkandmultiLineValueLinkrules to accept all three bracket types via newopenBracket/closeBracketrules_parse_line_content,_split_lines_respecting_quotes,_find_colon_outside_quotes,_parse_values, and_parse_valuefunctionsopen_bracketandclose_bracketcombinators for multiline link parsingopenBracketandcloseBracketrulesAll implementations also update the
referenceSymbolpatterns to exclude the new bracket characters from unquoted references.Examples
These are now equivalent:
Mixed delimiters also work:
Tests
Added comprehensive tests for each language implementation covering:
Version
Bumped to 0.13.0 across all implementations.
Test plan
Closes #143
🤖 Generated with Claude Code