Refactor: Move Matcher class to separate files and split into Full/Partial matchers #490
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding CLAUDE.md with task information for AI processing. This file will be removed when the task is complete. Issue: #123
…rtial matchers - Extract nested Matcher class from Sequences.cs (previously ~180 lines at line 631) - Split into separate classes for better separation of concerns: * SimpleFullMatcher - handles full sequence matching * SimplePartialMatcher - handles partial sequence matching * SimpleSequenceMatcherBase - shared base functionality * ISequenceMatcher - common interface - Maintain all original functionality while improving code organization - Update Sequences.cs to use new SimpleFullMatcher instead of nested class - Add basic SequencesOptions to resolve dependencies Fixes #123 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
konard
changed the title
🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Refactor the nested
Matcherclass fromSequences.csby moving it into separate files and splitting it into distinct classes for Full and Partial matching operations.Changes Made
Matcherclass fromSequences.cs(previously ~180 lines starting at line 631)SimpleFullMatcher- handles full sequence matching operationsSimplePartialMatcher- handles partial sequence matching operationsSimpleSequenceMatcherBase- shared base functionality and common patternsISequenceMatcher- common interface for polymorphic usageSequences.csto useSimpleFullMatcherinstead of the nested classSequencesOptionsbasic implementation to resolve dependenciesArchitecture Improvements
Files Created
Sequences/ISequenceMatcher.cs- Interface for sequence matching operationsSequences/SimpleSequenceMatcherBase.cs- Base class with shared functionalitySequences/SimpleFullMatcher.cs- Full matching implementationSequences/SimplePartialMatcher.cs- Partial matching implementationSequences/SequencesOptions.cs- Basic options classTest Plan
Fixes #123
🤖 Generated with Claude Code