-
Notifications
You must be signed in to change notification settings - Fork 12
Drawer shadow fixes #103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drawer shadow fixes #103
Conversation
Release v5.2.0 - staging → main
|
@davyd-akamai is this something we want to move forward with? cc: @abailly-akamai just in case |
|
@jaalah-akamai @abailly-akamai Yes, I think we can merge it, there is no upcoming changes in the nearest future. |
|
@davyd-akamai should we wait for UIE-9838? |
Yes, good point. Let me fix that first. |
…primaryHover' alias token
|
@abailly-akamai @aaleksee I’ve introduced a new “Neutral.85” global token and changed the value of the interaction token responsible for the table row hover color. This should resolve the issue highlighted in UIE-9838. It seems our neutral palette should be expanded to cover all dark mode scenarios, and I’m working on that. |
abailly-akamai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good ty @davyd-akamai !
dropdown.icon.defaulthas been renamed todropdown.icon.primary[major change]dropdown.background.selectedhas been changed tointeraction.background.primaryActivedropdown.background.categoryhas been changed tointeraction.background.neutralHoverdropdown.icon.secondarytokendropdown.border.defaulttokeninteraction.border.lighttoken for less prominent interactive bordersneutral.85token to expand a neutral paletteinteraction.background.primaryHoverhas been changed toneutral.85