Skip to content

Conversation

@bnussman-akamai
Copy link
Member

@bnussman-akamai bnussman-akamai commented May 19, 2025

Description 📝

  • Migrates from a hacky way of creating breakpoints to what seems like a slightly less hacky way
    • The function is prefixed with unstable_, but I think it's okay. Hopefully MUI will promote it to stable soon. Worst case we just revert this PR if we start seeing issues
    • The createBreakpints function has a confusing history. It existed a long time ago and we used it, but then it was removed in v5 (which is when we introduced the hacky approach), but then it was added back as unstable_createBreakpoints recently. Hopefully it is here to stay.... 🤞
    • In most cases, you can just define the breakpoints in the theme itself, but for our codebase, it is not that straightforward. See refactor: [M3-9591] - Cleanup token organization and paths #11867 (comment) for a long explanation

How to test 🧪

  • Checkout the PR or view preview link
  • Verify breakpoints still work as they did before as you shrink/expand the viewport
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All unit tests are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@bnussman-akamai bnussman-akamai self-assigned this May 19, 2025
@bnussman-akamai bnussman-akamai requested a review from a team as a code owner May 19, 2025 18:47
@bnussman-akamai bnussman-akamai requested review from bill-akamai and hana-akamai and removed request for a team May 19, 2025 18:47
@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🎉 593 passing tests on test run #2 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
0 Failing593 Passing4 Skipped102m 47s

Copy link
Contributor

@hana-akamai hana-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't notice any breakpoint regressions, thanks Banks! 🧹

@hana-akamai hana-akamai added the Add'tl Approval Needed Waiting on another approval! label May 19, 2025
Copy link
Contributor

@bill-akamai bill-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Breakpoints look good - thanks!

@github-project-automation github-project-automation bot moved this from Review to Approved in Cloud Manager May 21, 2025
@bnussman-akamai bnussman-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels May 21, 2025
@bnussman-akamai bnussman-akamai merged commit 63f6c0f into linode:develop May 21, 2025
35 checks passed
@github-project-automation github-project-automation bot moved this from Approved to Merged in Cloud Manager May 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved Multiple approvals and ready to merge! Tech Debt

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants