fix: [UIE-9531] - Exclude newly added unsaved rulesets from dropdown for the given Firewall

[pmakode-akamai]

Description 📝

• Follow-up to: upcoming: [UIE-9531] – Prevent referencing of RuleSet by a FW more than once #13169

Issue:
It is true that a user cannot add (or find a ruleset in the list of search results) a ruleset that has already been added and saved to a firewall. But a user can add duplicate ruleset of an unsaved ruleset.

Changes 🔄

• Replaced the saved state (rules.inbound / rules.outbound) with a draft/unsaved state (inboundRules / outboundRules) to prevent adding duplicate rulesets before saving

Scope 🚢

• All customers
• Some customers (e.g. in Beta or Limited Availability)
• No customers / Not applicable

Target release date 🗓️

Upcoming release

How to test 🧪

Prerequisites

• Enable the "RuleSets and Prefix Lists" feature flag
• Add the required customer tag to your account (mentioned in the parent ticket)

Reproduction steps

• Navigate to firewalls/:id/rules
• Add a ruleset to the firewall (let's assume it has the label 'rs123')
• Without saving the current changes, add another ruleset to the firewall, and you can see that 'rs123' is still visible in the search results of rulesets that are available to be added.
• Add rs123
• Click the 'save changes' button, and you will get an error that the changes failed to save.

Verification steps

• Ensure that a Rule Set already referenced before saving does not appear in the dropdown
• Ensure that a Rule Set already referenced after saving does not appear in the dropdown

Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support

• I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

• All tests and CI checks are passing
• TypeScript compilation succeeded without errors
• Code passes all linting rules

[linode-gh-bot]

Cloud Manager UI test results

🎉 870 passing tests on test run #2 ↗︎

❌ Failing	✅ Passing	↪️ Skipped	🕐 Duration
0 Failing	870 Passing	11 Skipped	44m 42s

[jdamore-linode]

Thanks @pmakode-akamai! Confirmed this prevents selected but unsaved rulesets from appearing in the drop-down