upcoming: [UIE-9430] - Delete Database Connection Pool dialog #13236
Conversation
.../features/Databases/DatabaseDetail/DatabaseNetworking/DatabaseConnectionPoolDeleteDialog.tsx
Outdated
Show resolved
Hide resolved
|
I was checking the spec and it looks like the pool label has this requirement: However, we currently have it include the
|
| title={`Delete Database Connection Pool ${poolLabel}`} | ||
| /> | ||
| ); | ||
| }; |
There was a problem hiding this comment.
There are some additional requirements for the delete dialog shown in the wireframes that are missing.
-
The title doesn't follow the format shown in the wireframes from tech writing. It should be:
{action} the {label} {object}?
So in this case, it would beDelete the {poolLabel} connection pool? -
In the wireframes, they have a warning notification banner that explains the impact of deleting a connection pool. That should also be added.
There was a problem hiding this comment.
From the discussion with tech writing on the dialog title format in the wireframes, there are likely other dialogs in DBaaS that will need to be updated, such as database delete. We should make make a follow up ticket to address the title format for those other dialogs for consistency.
There was a problem hiding this comment.
Added a comment in the figma, I added the to this dialog for now but I think the title reads cleaner without the the
There was a problem hiding this comment.
After further discussion, the title format will be discussed with tech writing.
smans-akamai
left a comment
smans-akamai
left a comment
There was a problem hiding this comment.
All my feedback has been addressed, so this looks good to me!
Cloud Manager UI test results🎉 870 passing tests on test run #6 ↗︎
|
4 participants
Description 📝
Add ability to delete a Connection Pool in the Database details -> Networking tab -> Manage PgBouncer Connection Pools section
Scope 🚢
Upon production release, changes in this PR will be visible to:
Preview 📷
Screen.Recording.2026-01-05.at.12.28.17.PM.mov
How to test 🧪
Prerequisites
(How to setup test environment)
Database PgBouncerfeature flag is onVerification steps
(How to verify changes)
http://localhost:3000/databases/postgresql/1/networking)Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅