logging: suppress logging except during normal output #3023
+15
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NateThornton
force-pushed
the
normal_output_only_logging_macros
branch
from
1a31c4b to
0bcbcbd
Compare
Suppress the logging macros `print_info` and `print_debug` except during normal output. This ensures that `json` and `binary` output formats do not include unnecessary warnings. This was originally causing issue with create-ns command printing warnings about namespace granularity alignment when using JSON option. See issue linux-nvme#2993. Signed-off-by: Nate Thornton <[email protected]>
NateThornton
force-pushed
the
normal_output_only_logging_macros
branch
from
0bcbcbd to
2aae8c4
Compare
NateThornton
changed the title
Contributor
Author
|
Closes #2993 |
Collaborator
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suppress the logging macros
print_infoandprint_debugexcept during "normal" output. This ensures that "json" and "binary" output formats do not include unnecessary warnings.This was originally causing issue with create-ns command printing warnings about namespace granularity alignment when using JSON option. See issue #2993.