Skip to content

fabrics: fix valgrind errors for connect-all using JSON config file #3033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
igaw merged 2 commits into from
Jan 5, 2026
+3 −1
Merged

fabrics: fix valgrind errors for connect-all using JSON config file #3033

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
53b57b5
fabrics: fix uninitialized value in _nvmf_discovery()
martin-gpy Jan 3, 2026
4958135
fabrics: fix mem leak at nvmf_discovery_config_file()
martin-gpy Jan 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion libnvme/src/nvme/fabrics.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2134,7 +2134,7 @@ static int _nvmf_discovery(struct nvme_global_ctx *ctx,
nvme_ctrl_t cl;
bool discover = false;
bool disconnect;
nvme_ctrl_t child;
nvme_ctrl_t child = { 0 };
int tmo = fctx->cfg->keep_alive_tmo;

struct fabric_args trcfg = {
Expand Down Expand Up @@ -2588,6 +2588,8 @@ int nvmf_discovery_config_file(struct nvme_global_ctx *ctx,
nvme_free_ctrl(c);
} while (!err);

fctx->parser_cleanup(fctx, fctx->user_data);

if (err != -EOF)
return err;

Expand Down
Loading