PyPI: add meson options to build without nvme executable #3047
+7
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that nvme-cli and libnvme live in the same GitHub repository, meson builds both by default. When building the PyPI package, however, we only want to build libnvme and the Python bindings, not the nvme executable. Signed-off-by: Martin Belanger <[email protected]>
Collaborator
|
Let's see if does the trick :) |
Collaborator
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that nvme-cli and libnvme live in the same GitHub repository, meson builds both by default. When building the PyPI package, however, we only want to build
libnvmeand the Python bindings, not thenvmeexecutable.@igaw - I think this will fix the PyPI issue. This adds "
-Dnvme=disabled -Dlibnvme=enabled -Dpython=enabled" to themeson setupoptions. If there are other options you would like to set (maybe--prefix,--sysconfdir,--buildtype, etc.) please feel free to update accordingly.