feat: issues of compile on Qt5.#171
Merged
deepin-bot[bot] merged 1 commit intolinuxdeepin:masterfrom Dec 23, 2025
Merged
Conversation
Adapted to the v20 system, issues of compile on Qt5. 适配v20系统,完成Qt5环境的编译流程。 v20 BUG 分支合一到v25主线 Task: https://pms.uniontech.com/task-view-383475.html
deepin pr auto review我来帮你分析这两处代码修改:
+#include <QRegularExpression>这是一个头文件添加,看起来是为了使用正则表达式功能。这个修改本身没有问题,但建议:
#if QT_VERSION_MAJOR >= 6
scaleAtPoint(event->position().toPoint(), factor);
#else
scaleAtPoint(event->pos(), factor);
#endif这是一个很好的 Qt 版本兼容性处理。建议:
总体评价:
这些修改都是安全的,不会影响代码的性能和安全性。主要是为了提高代码的兼容性和可维护性。 |
lzwind
approved these changes
Dec 23, 2025
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: lichaofan2008, lzwind The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
Author
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adapted to the v20 system, issues of compile on Qt5.
适配v20系统,完成Qt5环境的编译流程。
v20 BUG 分支合一到v25主线
Task: https://pms.uniontech.com/task-view-383475.html