-
Notifications
You must be signed in to change notification settings - Fork 2
Bump chart version to 0.4.4 #22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Andres Tobon <[email protected]>
WalkthroughBumped Helm chart version and adjusted how the OpenSearch scroll timeout is formatted in a migration script (changed to an integer-minute string). Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests
Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the Helm chart version for the lfx-v2-indexer-service from 0.4.3 to 0.4.4, representing a minor version bump for a new release.
- Incremented chart version to reflect new release
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
The scroll timeout needs to be in minutes format (e.g., "5m") rather than Go's duration string format. This fixes the scroll bad request error. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]> Signed-off-by: Andres Tobon <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Jira integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
scripts/migration/001_add_access_query_fields/main.go(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: MegaLinter
| "scroll_id": scrollID, | ||
| "scroll": scrollTimeout.String(), | ||
| "scroll": fmt.Sprintf("%dm", int(scrollTimeout.Minutes())), | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revert truncating the scroll timeout to whole minutes
Casting to int(scrollTimeout.Minutes()) floors anything below 60 seconds to 0m and drops the seconds component for values like 90s → 1m, changing the effective timeout and potentially invalidating the scroll context. Keep the original duration string so fractional minutes remain intact.
- "scroll": fmt.Sprintf("%dm", int(scrollTimeout.Minutes())),
+ "scroll": scrollTimeout.String(),📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "scroll_id": scrollID, | |
| "scroll": scrollTimeout.String(), | |
| "scroll": fmt.Sprintf("%dm", int(scrollTimeout.Minutes())), | |
| } | |
| "scroll_id": scrollID, | |
| "scroll": scrollTimeout.String(), | |
| } |
🤖 Prompt for AI Agents
In scripts/migration/001_add_access_query_fields/main.go around lines 248 to
250, the code currently truncates the scroll timeout to whole minutes via
int(scrollTimeout.Minutes()), which floors durations under a minute to "0m" and
drops seconds; change the payload to use the original duration string (e.g.,
scrollTimeout.String()) or otherwise format the duration to include seconds so
fractional minutes/seconds are preserved when sending the scroll timeout.
This pull request updates the chart version for the
lfx-v2-indexer-service. The only change is a minor version bump in the Helm chart metadata.versionfield from0.4.3to0.4.4incharts/lfx-v2-indexer-service/Chart.yamlto reflect a new release.