Do not leak Sendable extensions to consumers #848
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfed
commented
Nov 20, 2025
|
|
||
| // MARK: Collections | ||
|
|
||
| extension NSHashTable: @unchecked Swift.Sendable {} // cannot specify Obj-C generics |
dfed
commented
Nov 20, 2025
| import Foundation | ||
|
|
||
| /// A thin unchecked sendable wrapper around NSMapTable. | ||
| final class MapTable<KeyType, ObjectType>: @unchecked Sendable where KeyType: AnyObject, ObjectType: AnyObject { |
Author
There was a problem hiding this comment.
I did not implement every method on NSMapTable here. Just ones that were used.
dfed
commented
Nov 20, 2025
|
|
||
| extension AVCaptureDevice: @unchecked Swift.Sendable {} | ||
| extension AVCaptureDevice.Format: @unchecked Swift.Sendable {} | ||
| extension CVPixelBuffer: @unchecked Swift.Sendable {} |
Author
There was a problem hiding this comment.
I worked around this one locally – no need for a global change
dfed
commented
Nov 20, 2025
Comment on lines
57
to
58
| extension AVCaptureDevice: @unchecked Swift.Sendable {} | ||
| extension AVCaptureDevice.Format: @unchecked Swift.Sendable {} |
Author
There was a problem hiding this comment.
These two are effectively sendable per documentation, so I left them
dfed
commented
Nov 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LiveKit currently marks multiple types that are not thread-safe as being
Sendable. These extensions mean that consumer's applications also treat these types asSendable, which can lead to thread-safety bugs.This PR removes the Sendable extensions without adding new warnings. This is accomplished by utilizing internal wrapper types that are marked as
@unchecked Sendable.