Skip to content

Fix race condition during sync #861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pblazej merged 3 commits into from
Dec 9, 2025
Merged

Fix race condition during sync #861

pblazej merged 3 commits into from
Dec 9, 2025

Conversation

@pblazej
Copy link
Contributor

@pblazej pblazej commented Dec 5, 2025 •
edited
Loading

Resolves #859

Swift SDK uses isSubscribed which checks if a track is actually attached, but during reconnection, the PeerConnection hasn't fired the onTrack event yet, so the track is nil, making isSubscribed = false.

Using JS convention isDesired here.

@github-actions
Copy link

github-actions bot commented Dec 5, 2025

⚠️ This PR does not contain any files in the .changes directory.

@pblazej pblazej marked this pull request as ready for review December 9, 2025 08:24
@pblazej pblazej requested a review from hiroshihorie December 9, 2025 08:24
@pblazej
Copy link
Contributor Author

pblazej commented Dec 9, 2025

Upgrading swiftformat
0.57.2 -> 0.58.7

@pblazej pblazej merged commit 59d83d2 into main Dec 9, 2025
23 of 27 checks passed
@pblazej pblazej deleted the blaze/sync-state branch December 9, 2025 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hiroshihorie hiroshihorie hiroshihorie approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Reconnection complete before remote track set causing an incorrect state sync

3 participants

@pblazej @hiroshihorie