[fix] pickle error when import builtin #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Config file imports builtin module such as `os`, `sys`
should be supported:
```python
import os
import sys
d = dict(os=os.name, threads=os.cpu_count())
if sys.platform == "win32":
d.update(is_windows=True)
```
However, Config object contains non-lazy module can not
be pickled or copied.
We fix this issue by filtering out builtin modules, since
no one wants to access `os` or `sys` through Config.
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a pickle error that occurs when config files import builtin modules like os and sys. The issue was that Config objects containing non-lazy builtin modules could not be pickled or copied.
- Added filtering logic to exclude builtin modules from Config objects during parsing
- Incremented version number to 0.10.11
- Added comprehensive test coverage for the fix
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| mme/config/config.py | Added module filtering in _parse_lazy_import to skip builtin modules |
| tests/test_config/test_import_builtin.py | New test file validating builtin module handling and pickle compatibility |
| tests/data/config/lazy_module_config/test_mix_builtin.py | Test config file importing builtin modules |
| mme/init.py | Version bump from 0.10.10 to 0.10.11 |
Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Config file imports builtin module such as
os,sysshould be supported:However, Config object contains non-lazy module can not be pickled or copied.
We fix this issue by filtering out builtin modules, since no one wants to access
osorsysthrough Config.