Skip to content

Conversation

@wizardengineer
Copy link
Contributor

@wizardengineer wizardengineer commented Sep 3, 2025

Related Issue: #1885

@github-actions
Copy link

github-actions bot commented Sep 3, 2025

✅ With the latest revision this PR passed the C/C++ code formatter.

@lanza lanza force-pushed the main branch 2 times, most recently from 8acaf96 to 58135ea Compare October 20, 2025 17:19
@wizardengineer wizardengineer marked this pull request as ready for review October 28, 2025 23:46
Copy link
Member

@bcardosolopes bcardosolopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! @AmrDeveloper anything else?

bcardosolopes pushed a commit that referenced this pull request Nov 4, 2025
A simple clean up, just some small changes for the use explicitly types
instead of `auto`. In the case of `BI__builtin_ia32_pslldqi*_byteshift`.

Following the suggestion of this comment:
#1886 (comment)
@bcardosolopes bcardosolopes changed the title [CIR] Added support for __builtin_ia32_psrldqi_byteshift [CIR] Add support for __builtin_ia32_psrldqi_byteshift Nov 4, 2025
Copy link
Member

@AmrDeveloper AmrDeveloper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks

@bcardosolopes bcardosolopes merged commit 657d213 into llvm:main Nov 4, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants