Skip to content

Conversation

@xlauko
Copy link
Collaborator

@xlauko xlauko commented Nov 2, 2025

@xlauko xlauko marked this pull request as ready for review November 2, 2025 12:31
@xlauko
Copy link
Collaborator Author

xlauko commented Nov 2, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Collaborator

@andykaylor andykaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm -- Thanks for handling this!

Are there still missing cases in the builders where we are calling free create functions via the this pointer? We had a number of those upstream that needed to be fixed after a bulk change like this.

@xlauko
Copy link
Collaborator Author

xlauko commented Nov 3, 2025

lgtm -- Thanks for handling this!

Are there still missing cases in the builders where we are calling free create functions via the this pointer? We had a number of those upstream that needed to be fixed after a bulk change like this.

I believe I got all of them, but I will double check.

@xlauko xlauko force-pushed the users/xlauko/cir-create-funtion-update branch from dddfe5c to c53151e Compare November 3, 2025 17:55
@xlauko xlauko merged commit f60335d into main Nov 4, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants