💄 style: add new bedrock model support #9826
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Someone is attempting to deploy a commit to the LobeHub Community Team on Vercel. A member of the Team first needs to authorize it. |
dosubot
bot
added
the
size:M
Reviewer's GuideAdds support for Anthropic’s Claude Sonnet 4.5 and Claude Haiku 4.5 by defining them in the model bank, exposing them through the Bedrock provider UI, and updating constant ID sets for caching, tooling, and parameter resolution. ER diagram for updated model ID sets for caching and toolingerDiagram
CONTEXT_CACHING_MODELS {
string id
}
THINKING_WITH_TOOL_CLAUDE_MODELS {
string id
}
CONTEXT_CACHING_MODELS ||--o| "Claude Sonnet 4.5" : contains
CONTEXT_CACHING_MODELS ||--o| "Claude Haiku 4.5" : contains
THINKING_WITH_TOOL_CLAUDE_MODELS ||--o| "Claude Sonnet 4.5" : contains
THINKING_WITH_TOOL_CLAUDE_MODELS ||--o| "Claude Haiku 4.5" : contains
"Claude Sonnet 4.5" {
string id
}
"Claude Haiku 4.5" {
string id
}
File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
TestGru AssignmentSummary
Files
Tip You can |
|
Thank you for raising your pull request and contributing to our Community |
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey there - I've reviewed your changes - here's some feedback:
- Consider centralizing the new model metadata (IDs, flags, pricing, etc.) into a shared constant to avoid manual duplication across model-bank, config, and const files.
- I noticed
structuredOutputandreasoningflags are set in model-bank but not in themodelProviders/bedrock.tsentries; please ensure feature flags are consistently applied across both listings.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider centralizing the new model metadata (IDs, flags, pricing, etc.) into a shared constant to avoid manual duplication across model-bank, config, and const files.
- I noticed `structuredOutput` and `reasoning` flags are set in model-bank but not in the `modelProviders/bedrock.ts` entries; please ensure feature flags are consistently applied across both listings.
## Individual Comments
### Comment 1
<location> `packages/model-runtime/src/core/parameterResolver.ts:266` </location>
<code_context>
'claude-opus-4-20250514',
'claude-sonnet-4-20250514',
'claude-sonnet-4-5-20250929',
+ 'claude-haiku-4-5-20251001',
// Bedrock model IDs
'anthropic.claude-opus-4-1-20250805-v1:0',
</code_context>
<issue_to_address>
**issue:** The model ID 'claude-haiku-4-5-20251001' is added without a ':v1:0' suffix, unlike other IDs.
Please update the model ID to match the format used for other entries to avoid potential lookup or parameter issues.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Removed Claude Sonnet 4.5 and Claude Haiku 4.5 model configurations from the Bedrock provider config file as per reviewer request. The model definitions remain in the model bank (packages/model-bank/src/aiModels/bedrock.ts) and can be enabled once needed.
arvinxx
changed the title
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9826 +/- ##
==========================================
- Coverage 84.55% 84.54% -0.01%
==========================================
Files 943 944 +1
Lines 64465 64510 +45
Branches 9534 9307 -227
==========================================
+ Hits 54508 54543 +35
- Misses 9957 9967 +10
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💻 Change Type
🔀 Description of Change
Added support for the latest Claude 4.5 models on AWS Bedrock:
Model Bank (
packages/model-bank/src/aiModels/bedrock.ts):Claude Sonnet 4.5 (
us.anthropic.claude-sonnet-4-5-20250929-v1:0)Claude Haiku 4.5 (
us.anthropic.claude-haiku-4-5-20251001-v1:0)API Constants (
packages/const/src/models.ts):contextCachingModelsset for cache supportthinkingWithToolClaudeModelsset for reasoning capabilitiesParameter Resolver (
packages/model-runtime/src/core/parameterResolver.ts):MODEL_PARAMETER_CONFLICTSto include the new model IDsNote: As per reviewer feedback, removed the model provider configuration from
src/config/modelProviders/bedrock.ts. The model definitions remain in the model bank and can be enabled once needed.📝 Additional Information
These are the latest Claude 4.5 series models available on AWS Bedrock. The models are fully defined in the model bank with complete specifications, pricing, and capabilities. They can be activated in the provider configuration when ready for production use.