- 
          
 - 
                Notifications
    
You must be signed in to change notification settings  - Fork 13.9k
 
💄 style: adjust modal setting form styles for improved layout and responsiveness #9890
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| 
           @bbbugg is attempting to deploy a commit to the LobeHub Community Team on Vercel. A member of the Team first needs to authorize it.  | 
    
          
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR adjusts the layout of two setting modals by injecting a responsive styles prop that constrains their height and enforces a flex-column layout, preventing overflow on high-zoom or lower-resolution screens. Class diagram for updated modal components with responsive stylesclassDiagram
  class ModelConfigModal {
    +open: boolean
    +setOpen: function
    +styles: object
    +closeModal(): void
    +styles_content: "flex column"
    +styles_maxHeight: number
  }
  class CreateNewModelModal {
    +open: boolean
    +setOpen: function
    +styles: object
    +closeModal(): void
    +styles_content: "flex column"
    +styles_maxHeight: number
  }
  ModelConfigModal <|-- CreateNewModelModal
    File-Level Changes
 Possibly linked issues
 Tips and commandsInteracting with Sourcery
 Customizing Your ExperienceAccess your dashboard to: 
 Getting Help
  | 
    
          TestGru AssignmentSummary
 Tip You can   | 
    
| 
           👍 @bbbugg Thank you for raising your pull request and contributing to our Community  | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
          Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@            Coverage Diff            @@
##             main    #9890     +/-   ##
=========================================
  Coverage   84.49%   84.49%             
=========================================
  Files         944      944             
  Lines       64879    64879             
  Branches     9618     7951   -1667     
=========================================
  Hits        54818    54818             
  Misses      10061    10061             
 Flags with carried forward coverage won't be shown. Click here to find out more. 
 🚀 New features to boost your workflow:
  | 
    
| 
           Actually, I personally think it would be better to change the model settings modal to a sidebar drawer in the future. 
 Original Content其实我个人感觉,后面模型设置弹窗应该改成侧边栏的抽屉会更好一些 | 
    
| 
           ❤️ Great PR @bbbugg ❤️ The growth of project is inseparable from user feedback and contribution, thanks for your contribution! If you are interesting with the lobehub developer community, please join our discord and then dm @arvinxx or @canisminor1990. They will invite you to our private developer channel. We are talking about the lobe-chat development or sharing ai newsletter around the world.  | 
    
### [Version 1.142.3](v1.142.2...v1.142.3) <sup>Released on **2025-10-27**</sup> #### 💄 Styles - **misc**: Adjust modal setting form styles for improved layout and responsiveness, Unzip file when uploading in knowledge base [LOB-500]. <br/> <details> <summary><kbd>Improvements and Fixes</kbd></summary> #### Styles * **misc**: Adjust modal setting form styles for improved layout and responsiveness, closes [#9890](#9890) ([1997ec5](1997ec5)) * **misc**: Unzip file when uploading in knowledge base [LOB-500], closes [#9854](#9854) ([e568ce6](e568ce6)) </details> <div align="right"> [](#readme-top) </div>
| 
           🎉 This PR is included in version 1.142.3 🎉 The release is available on: Your semantic-release bot 📦🚀  | 
    
## [Version 1.135.0](v1.134.0...v1.135.0) <sup>Released on **2025-10-27**</sup> #### ♻ Code Refactoring - **misc**: Change discover page from RSC to SPA to improve performance. #### ✨ Features - **misc**: Use env to control clerk allow origin feature. #### 🐛 Bug Fixes - **misc**: Loadmore not work & navbar not show in pwa. #### 💄 Styles - **misc**: Adjust modal setting form styles for improved layout and responsiveness, Allow removal of `top_p` and similar request parameters, improve local system tools render, improve provider modal height when creating custom provider, Improvement for Agent Team After Alpha Launch [LOB-517], Unzip file when uploading in knowledge base [LOB-500], update i18n. <br/> <details> <summary><kbd>Improvements and Fixes</kbd></summary> #### Code refactoring * **misc**: Change discover page from RSC to SPA to improve performance, closes [lobehub#9828](https://github.com/jaworldwideorg/OneJA-Bot/issues/9828) ([b59ee0a](b59ee0a)) #### What's improved * **misc**: Use env to control clerk allow origin feature, closes [lobehub#9863](https://github.com/jaworldwideorg/OneJA-Bot/issues/9863) ([490fee0](490fee0)) #### What's fixed * **misc**: Loadmore not work & navbar not show in pwa, closes [lobehub#9855](https://github.com/jaworldwideorg/OneJA-Bot/issues/9855) ([411f875](411f875)) #### Styles * **misc**: Adjust modal setting form styles for improved layout and responsiveness, closes [lobehub#9890](https://github.com/jaworldwideorg/OneJA-Bot/issues/9890) ([1997ec5](1997ec5)) * **misc**: Allow removal of `top_p` and similar request parameters, closes [lobehub#9498](https://github.com/jaworldwideorg/OneJA-Bot/issues/9498) ([4c313ce](4c313ce)) * **misc**: Improve local system tools render, closes [lobehub#9853](https://github.com/jaworldwideorg/OneJA-Bot/issues/9853) ([295e8fc](295e8fc)) * **misc**: Improve provider modal height when creating custom provider, closes [lobehub#9870](https://github.com/jaworldwideorg/OneJA-Bot/issues/9870) ([55d92c0](55d92c0)) * **misc**: Improvement for Agent Team After Alpha Launch [LOB-517], closes [lobehub#9748](https://github.com/jaworldwideorg/OneJA-Bot/issues/9748) ([28245be](28245be)) * **misc**: Unzip file when uploading in knowledge base [LOB-500], closes [lobehub#9854](https://github.com/jaworldwideorg/OneJA-Bot/issues/9854) ([e568ce6](e568ce6)) * **misc**: Update i18n, closes [lobehub#9862](https://github.com/jaworldwideorg/OneJA-Bot/issues/9862) ([8d3bc91](8d3bc91)) </details> <div align="right"> [](#readme-top) </div>
💻 Change Type
🔗 Related Issue
🔀 Description of Change
在1920*1080分辨率、125%缩放的屏幕上打开模型设置form显示不全,需要往下滚动才行。实际上,通过浏览器页面缩放就能触发。
看到 #9870 想到模型设置form也有类似的显示问题。
🧪 How to Test
📸 Screenshots / Videos
📝 Additional Information
Summary by Sourcery
Apply consistent inline styles to model setting modals to constrain height and arrange content in a flex column layout, preventing overflow on high-resolution or zoomed screens
Bug Fixes:
Enhancements: