Skip to content

Conversation

@bbbugg
Copy link
Contributor

@bbbugg bbbugg commented Oct 26, 2025

💻 Change Type

  • ✨ feat
  • 🐛 fix
  • ♻️ refactor
  • 💄 style
  • 👷 build
  • ⚡️ perf
  • ✅ test
  • 📝 docs
  • 🔨 chore

🔗 Related Issue

🔀 Description of Change

在1920*1080分辨率、125%缩放的屏幕上打开模型设置form显示不全,需要往下滚动才行。实际上,通过浏览器页面缩放就能触发。
看到 #9870 想到模型设置form也有类似的显示问题。

🧪 How to Test

  • Tested locally
  • Added/updated tests
  • No tests needed

📸 Screenshots / Videos

Before After
208d92029f6fcdc3c84809b80ec7f36d
ec43498e3668a6ec0cb872bccf67e18d
38e2d2535dcdc78c75c17c6f70a4fce9
7c7344735ead0929e5ef8e5f1a67e30b

📝 Additional Information

Summary by Sourcery

Apply consistent inline styles to model setting modals to constrain height and arrange content in a flex column layout, preventing overflow on high-resolution or zoomed screens

Bug Fixes:

  • Prevent model setting forms from overflowing and requiring scroll on high-DPI or zoomed viewports

Enhancements:

  • Add flex column display and max-height constraint to CreateNewModelModal
  • Add flex column display and max-height constraint to ModelConfigModal

@vercel
Copy link

vercel bot commented Oct 26, 2025

@bbbugg is attempting to deploy a commit to the LobeHub Community Team on Vercel.

A member of the Team first needs to authorize it.

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Oct 26, 2025
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Oct 26, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR adjusts the layout of two setting modals by injecting a responsive styles prop that constrains their height and enforces a flex-column layout, preventing overflow on high-zoom or lower-resolution screens.

Class diagram for updated modal components with responsive styles

classDiagram
  class ModelConfigModal {
    +open: boolean
    +setOpen: function
    +styles: object
    +closeModal(): void
    +styles_content: "flex column"
    +styles_maxHeight: number
  }
  class CreateNewModelModal {
    +open: boolean
    +setOpen: function
    +styles: object
    +closeModal(): void
    +styles_content: "flex column"
    +styles_maxHeight: number
  }
  ModelConfigModal <|-- CreateNewModelModal
Loading

File-Level Changes

Change Details Files
Constrain modal content height and enforce flex-column layout
  • Add styles prop to wrap modal content
  • Set content display to 'flex' and flexDirection to 'column'
  • Limit content height with maxHeight: 'calc(100vh - 150px)'
src/app/[variants]/(main)/settings/provider/features/ModelList/CreateNewModelModal/index.tsx
src/app/[variants]/(main)/settings/provider/features/ModelList/ModelConfigModal/index.tsx

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@gru-agent
Copy link
Contributor

gru-agent bot commented Oct 26, 2025

TestGru Assignment

Summary

Link CommitId Status Reason
Detail bd41cbe 🚫 Skipped No files need to be tested {"src/app/[variants]/(main)/settings/provider/features/ModelList/CreateNewModelModal/index.tsx":"File path does not match include patterns.","src/app/[variants]/(main)/settings/provider/features/ModelList/ModelConfigModal/index.tsx":"File path does not match include patterns."}

History Assignment

Tip

You can @gru-agent and leave your feedback. TestGru will make adjustments based on your input

@lobehubbot
Copy link
Member

👍 @bbbugg

Thank you for raising your pull request and contributing to our Community
Please make sure you have followed our contributing guidelines. We will review it as soon as possible.
If you encounter any problems, please feel free to connect with us.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@codecov
Copy link

codecov bot commented Oct 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.49%. Comparing base (1fe6a59) to head (bd41cbe).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##             main    #9890     +/-   ##
=========================================
  Coverage   84.49%   84.49%             
=========================================
  Files         944      944             
  Lines       64879    64879             
  Branches     9618     7951   -1667     
=========================================
  Hits        54818    54818             
  Misses      10061    10061             
Flag Coverage Δ
app 80.06% <ø> (ø)
database 98.40% <ø> (ø)
packages/agent-runtime 98.37% <ø> (ø)
packages/context-engine 93.58% <ø> (ø)
packages/electron-server-ipc 93.76% <ø> (ø)
packages/file-loaders 92.21% <ø> (ø)
packages/model-bank 100.00% <ø> (ø)
packages/model-runtime 92.16% <ø> (ø)
packages/prompts 77.29% <ø> (ø)
packages/python-interpreter 96.50% <ø> (ø)
packages/utils 94.50% <ø> (ø)
packages/web-crawler 97.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Store 74.37% <ø> (ø)
Services 61.69% <ø> (ø)
Server 77.39% <ø> (ø)
Libs 50.82% <ø> (ø)
Utils 75.00% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bbbugg bbbugg changed the title fix: adjust modal setting form styles for improved layout and responsiveness 🐛 fix: adjust modal setting form styles for improved layout and responsiveness Oct 26, 2025
@arvinxx arvinxx changed the title 🐛 fix: adjust modal setting form styles for improved layout and responsiveness 💄 style: adjust modal setting form styles for improved layout and responsiveness Oct 27, 2025
@arvinxx
Copy link
Member

arvinxx commented Oct 27, 2025

Actually, I personally think it would be better to change the model settings modal to a sidebar drawer in the future.


This comment was translated by Claude.

Original Content 其实我个人感觉,后面模型设置弹窗应该改成侧边栏的抽屉会更好一些

@arvinxx arvinxx merged commit 1997ec5 into lobehub:main Oct 27, 2025
32 of 34 checks passed
@lobehubbot
Copy link
Member

❤️ Great PR @bbbugg ❤️

The growth of project is inseparable from user feedback and contribution, thanks for your contribution! If you are interesting with the lobehub developer community, please join our discord and then dm @arvinxx or @canisminor1990. They will invite you to our private developer channel. We are talking about the lobe-chat development or sharing ai newsletter around the world.

lobehubbot pushed a commit that referenced this pull request Oct 27, 2025
### [Version&nbsp;1.142.3](v1.142.2...v1.142.3)
<sup>Released on **2025-10-27**</sup>

#### 💄 Styles

- **misc**: Adjust modal setting form styles for improved layout and responsiveness, Unzip file when uploading in knowledge base [LOB-500].

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### Styles

* **misc**: Adjust modal setting form styles for improved layout and responsiveness, closes [#9890](#9890) ([1997ec5](1997ec5))
* **misc**: Unzip file when uploading in knowledge base [LOB-500], closes [#9854](#9854) ([e568ce6](e568ce6))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
@lobehubbot
Copy link
Member

🎉 This PR is included in version 1.142.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@bbbugg bbbugg deleted the fix-modelSettingForm branch October 27, 2025 04:40
JamieStivala pushed a commit to jaworldwideorg/OneJA-Bot that referenced this pull request Oct 27, 2025
## [Version&nbsp;1.135.0](v1.134.0...v1.135.0)
<sup>Released on **2025-10-27**</sup>

#### ♻ Code Refactoring

- **misc**: Change discover page from RSC to SPA to improve performance.

#### ✨ Features

- **misc**: Use env to control clerk allow origin feature.

#### 🐛 Bug Fixes

- **misc**: Loadmore not work & navbar not show in pwa.

#### 💄 Styles

- **misc**: Adjust modal setting form styles for improved layout and responsiveness, Allow removal of `top_p` and similar request parameters, improve local system tools render, improve provider modal height when creating custom provider, Improvement for Agent Team After Alpha Launch [LOB-517], Unzip file when uploading in knowledge base [LOB-500], update i18n.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### Code refactoring

* **misc**: Change discover page from RSC to SPA to improve performance, closes [lobehub#9828](https://github.com/jaworldwideorg/OneJA-Bot/issues/9828) ([b59ee0a](b59ee0a))

#### What's improved

* **misc**: Use env to control clerk allow origin feature, closes [lobehub#9863](https://github.com/jaworldwideorg/OneJA-Bot/issues/9863) ([490fee0](490fee0))

#### What's fixed

* **misc**: Loadmore not work & navbar not show in pwa, closes [lobehub#9855](https://github.com/jaworldwideorg/OneJA-Bot/issues/9855) ([411f875](411f875))

#### Styles

* **misc**: Adjust modal setting form styles for improved layout and responsiveness, closes [lobehub#9890](https://github.com/jaworldwideorg/OneJA-Bot/issues/9890) ([1997ec5](1997ec5))
* **misc**: Allow removal of `top_p` and similar request parameters, closes [lobehub#9498](https://github.com/jaworldwideorg/OneJA-Bot/issues/9498) ([4c313ce](4c313ce))
* **misc**: Improve local system tools render, closes [lobehub#9853](https://github.com/jaworldwideorg/OneJA-Bot/issues/9853) ([295e8fc](295e8fc))
* **misc**: Improve provider modal height when creating custom provider, closes [lobehub#9870](https://github.com/jaworldwideorg/OneJA-Bot/issues/9870) ([55d92c0](55d92c0))
* **misc**: Improvement for Agent Team After Alpha Launch [LOB-517], closes [lobehub#9748](https://github.com/jaworldwideorg/OneJA-Bot/issues/9748) ([28245be](28245be))
* **misc**: Unzip file when uploading in knowledge base [LOB-500], closes [lobehub#9854](https://github.com/jaworldwideorg/OneJA-Bot/issues/9854) ([e568ce6](e568ce6))
* **misc**: Update i18n, closes [lobehub#9862](https://github.com/jaworldwideorg/OneJA-Bot/issues/9862) ([8d3bc91](8d3bc91))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

released size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants