wasm support #23
Merged
wasm support #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parth
requested changes
Feb 24, 2025
Member
Parth
left a comment
Parth
left a comment
There was a problem hiding this comment.
you also should bump versions on the two crates here so we can release this change
db/src/logger.rs
Outdated
|
|
||
| if config.fs_locks { | ||
| if config.fs_locks_block { | ||
| #[cfg(not(target_family = "wasm"))] |
Member
There was a problem hiding this comment.
I believe you can add this check to the if statement on 242 to get rid of the double cfg on both branches
Member
There was a problem hiding this comment.
if someone tries to use fs_locks and is on wasm we should either panic or return an error (not silently continue to work)
db/src/logger.rs
Outdated
| } | ||
| } | ||
|
|
||
| #[cfg(not(target_family = "wasm"))] |
Member
There was a problem hiding this comment.
is the idea of impl'ing drop incompatible with wasm or just the unlock statement? if it's the later then just be more surgical with the cfg
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.