feat: add support for Header #233
Merged
+983
−498
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lization - Add getScreenWidth() utility method to ScreenUtils for consistent screen calculations - Update TrueSheetView to immediately update state when stateWrapper is set - Ensures initial container width is available before controller emits size changes - Improves initial render performance and prevents layout shift
- Reset _lastStateSize in prepareForRecycle - Updated example sheets
- Add TrueSheetHeaderView native component for iOS and Android - Add header prop to TrueSheet component - Subtract header height from container height in state for proper content layout - Update documentation for header feature
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
- Add headerHeight property to TrueSheetViewController - Include header height in totalHeight for auto detent calculation - Implement containerViewHeaderDidChangeSize delegate in TrueSheetView - Add headerHeight method to TrueSheetContainerView - Simplify scroll view pinning by passing header view directly - Re-apply scroll view pinning when header is added/removed - Update TrueSheetHeaderView registration in package.json codegenConfig - Update AGENTS.md with current project structure - Simplify migration.mdx examples
- Rename pinScrollView to scrollViewPinningEnabled for clarity - Track scrollViewPinningSet flag to handle header mount/unmount - Re-apply scroll view pinning when header is mounted/unmounted - Fix unpinView to remove constraints from parent view - Call headerDidChangeSize delegate on header mount/unmount
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Native Header View Component
This PR introduces a native
Headercomponent that allows rendering content at the top of the sheet that remains fixed while the sheet content scrolls. The header height is now included in auto detent calculations for accurate sheet sizing.Features
TrueSheet.Headercomponent for fixed header contentViewPropsfor better customizationBug Fixes
iOS
didLayoutSubviewsfor more accurate size reportingAndroid
...restprops spreadingDocumentation
minHeightworkaround for Android ScrollView drag issuesChanges
TrueSheetHeaderView.kt,TrueSheetHeaderViewManager.kt,TrueSheetContainerView.kt,TrueSheetViewController.kt,TrueSheetView.kt,ScreenUtils.ktTrueSheetHeaderView.h/mm,TrueSheetContainerView.h/mm,TrueSheetViewController.mm,TrueSheetView.mm,TrueSheetContentView.mm,LayoutUtil.mmTrueSheet.tsx,TrueSheet.types.ts,TrueSheetHeaderViewNativeComponent.tsheader.mdx,scrolling.mdx,troubleshooting.mdx,migration.mdx,props.mdx