Skip to content

Fix bulk logging broken #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alexanderweiss wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix bulk logging broken #81

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bcb7f45
Fix bulk logging not sending all logs
alexanderweiss Nov 11, 2024
13c4b39
Fix bulk logging not applying tags
alexanderweiss Nov 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lib/loggly/common.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ common.loggly = function () {
}
}
var requestOptions = {
uri: (isBulk && headers['X-LOGGLY-TAG']) ? uri + '/tag/' + headers['X-LOGGLY-TAG'] : uri,
url: (isBulk && headers['X-LOGGLY-TAG']) ? uri + '/tag/' + headers['X-LOGGLY-TAG'] : uri,
method: method,
headers: isBulk ? {} : headers || {}, // Set headers empty for bulk
proxy: proxy,
Expand Down Expand Up @@ -233,12 +233,12 @@ common.loggly = function () {
// Join Array Message with new line ('\n') character
//
if (arrMsg.length) {
requestOptions.body = arrMsg.join('\n');
requestOptions.data = arrMsg.join('\n');
arrMsg.length = 0;
}
try {
// eslint-disable-next-line no-unused-vars
axios(uri, requestOptions).then(function(res){
axios(requestOptions).then(function(res){
const responseCode = res.status;
if (responseCode === httpStatusCode.badToken.code) {
isValidToken = false;
Expand Down