feat: add extraParams to pass custom authorization parameters #140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for passing additional parameters to the authorization endpoint during sign-in. The feature allows developers to pass extra query parameters (e.g., tenant_id, ui_locales) that will be appended to the authorization URL.
Key changes:
- Added
extraParamsparameter togenerateSignInUrifunction in LogtoCore - Propagated
extraParamsthrough LogtoAuthSession and LogtoClient - Added public API method for sign-in with extra parameters
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| Sources/Logto/Core/LogtoCore+Generate.swift | Added extraParams parameter to generateSignInUri and appends them to the query string |
| Sources/LogtoClient/LogtoAuthSession/LogtoAuthSession.swift | Added extraParams property and passes it to generateSignInUri |
| Sources/LogtoClient/LogtoClient/LogtoClient+SignIn.swift | Added extraParams parameter to internal method and new public API method |
| Tests/LogtoTests/LogtoCoreTests+Generate.swift | Added test case verifying extra parameters are correctly added to the URI |
| Tests/LogtoClientTests/LogtoClient/LogtoClientTests+SignIn.swift | Added mock and test case to verify extra parameters are passed through correctly |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Change extraParams parameter from optional to required in signInWithBrowser method to ensure explicit parameter passing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds extraParams parameter to the Swift SDK's sign-in flow. This enables developers to pass custom query parameters to the OIDC authorization endpoint.
Testing
Checklist