feat: decode user data from JWT access token and add impersonated property #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmontoyaa
reviewed
Sep 17, 2024
arthuracs
force-pushed
the
get-userdata-from-accesstoken
branch
from
dd276d9 to
811f303
Compare
arthuracs
changed the title
arthuracs
force-pushed
the
get-userdata-from-accesstoken
branch
from
811f303 to
4e24dcb
Compare
arthuracs
force-pushed
the
get-userdata-from-accesstoken
branch
from
4e24dcb to
87e3f5d
Compare
ondrejsevcik
approved these changes
Oct 23, 2024
Contributor
ondrejsevcik
left a comment
ondrejsevcik
left a comment
There was a problem hiding this comment.
LGTM 👍🏼 Only a few cosmetic issues.
| name: z.string(), | ||
| profilePictureUrl: z.string().nullable().optional(), | ||
| tenantId: z.string(), | ||
| act: z |
Contributor
There was a problem hiding this comment.
🟢 It would be good to add some link to Frontegg docs for this variable. For someone like me (who sees this first time), it would be very helpful.
Author
There was a problem hiding this comment.
Unfortunately there are none.
AbdallahAHO
approved these changes
Oct 23, 2024
|
🎉 This PR is included in version 1.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AP-5345
Instead of making another GET request to
/frontegg/identity/resources/users/v2/mewe can decode the same information from the JWT access token that we already received from thesilentortokenendpoints.This PR also adds an
impersonated: booleanproperty to the user data response to determine whether the current session is impersonated.