Skip to content

feat: throw a custom error when parsing the Frontegg response fails #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 19, 2024
Merged

feat: throw a custom error when parsing the Frontegg response fails #35

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d24e08e
throw a custom error when parsing the frontegg response fails
Sep 17, 2024
2556259
conditionally include response body
Sep 17, 2024
65c9496
Merge branch 'main' into AP-4979_log-trace-id
arthuracs Sep 17, 2024
4762a76
Merge branch 'main' into AP-4979_log-trace-id
ondrejsevcik Sep 18, 2024
1e9476b
Include response object keys in error
Sep 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 19 additions & 5 deletions src/frontegg-oauth-client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,11 +297,25 @@ export class FronteggOAuthClient {
})

const json: unknown = await response.json()
const data = GET_FRONTEGG_TOKEN_RESPONSE_SCHEMA.parse(json)
this.accessToken = data.access_token
this.refreshToken = data.refresh_token
this.tokenExpirationTime = calculateTokenExpirationTime(data.expires_in)
return this.accessToken
try {
const data = GET_FRONTEGG_TOKEN_RESPONSE_SCHEMA.parse(json)

this.accessToken = data.access_token
this.refreshToken = data.refresh_token
this.tokenExpirationTime = calculateTokenExpirationTime(data.expires_in)
return this.accessToken
} catch (error: unknown) {
throw new FronteggError({
text: 'Error while parsing Frontegg response.',
status: 500,
url: `${this.baseUrl}/frontegg/oauth/authorize/silent`,
fronteggTraceId: response.headers.get('frontegg-trace-id') ?? 'undefined',
body: {
responseKeys: typeof json === 'object' && json !== null ? Object.keys(json) : undefined,
error,
},
})
}
}

/**
Expand Down