This repository was archived by the owner on Sep 22, 2025. It is now read-only.
Use proper install commands with glob for commit hash #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Felicitas Pojtinger <[email protected]>
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Comment on lines
31
to
32
| - grubby --set-default /boot/vmlinuz-6.7.12-pvm-host-fedora-hetzner | ||
| - grubby --copy-default --args="pti=off nokaslr lapic=notscdeadline" --update-kernel /boot/vmlinuz-6.7.12-pvm-host-fedora-hetzner |
Contributor
There was a problem hiding this comment.
The grubby commands still use static paths to kernel files (/boot/vmlinuz-6.7.12-pvm-host-fedora-hetzner) that don't account for the commit hash that's now included in package names. If the actual kernel files in /boot follow the same naming pattern as the packages (with commit hash), these commands will fail to find the kernel files.
Consider updating these paths to use wildcards or a more dynamic approach that matches the actual filenames in /boot. For example:
grubby --set-default /boot/vmlinuz-6.7.12-pvm-host-fedora-hetzner*
This would ensure the commands work correctly with the new naming convention that includes commit hashes.
Suggested change
| - grubby --set-default /boot/vmlinuz-6.7.12-pvm-host-fedora-hetzner | |
| - grubby --copy-default --args="pti=off nokaslr lapic=notscdeadline" --update-kernel /boot/vmlinuz-6.7.12-pvm-host-fedora-hetzner | |
| - grubby --set-default /boot/vmlinuz-6.7.12-pvm-host-fedora-hetzner* | |
| - grubby --copy-default --args="pti=off nokaslr lapic=notscdeadline" --update-kernel /boot/vmlinuz-6.7.12-pvm-host-fedora-hetzner* | |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently, we added the commit hash of the kernel we're building to the kernel
EXTRAVERSION; this adjusts the install commands accordingly.