[simple_system] Argument parsing fix #2356
Open
+5
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All these commands were working in Bash but not in Fish. This commit removes the = between the field and the value and replaces this with the more portable space. It also changes the commands in the readme to use the pipe input instead of setting the argument variable. This is because otherwise shells like fish interpret the output of the ibex_config.py scripts as one long string instead of multiple arguments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All these commands were working in Bash but not in Fish. This commit removes the = between the field and the value and replaces this with the more portable space. It also changes the commands in the readme to use the pipe input instead of setting the argument variable. This is because otherwise shells like fish interpret the output of the ibex_config.py scripts as one long string instead of multiple arguments.