Update default version of launch template#47
Open
madmatvey wants to merge 3 commits intolserman:masterfrom
Open
Update default version of launch template#47madmatvey wants to merge 3 commits intolserman:masterfrom
madmatvey wants to merge 3 commits intolserman:masterfrom
Conversation
Owner
|
Hey, I'll look into getting these merged. Haven't maintained this repo in awhile. Think you could add a test here? Looks like there is a test for this but it must be wrong. Thanks! |
Author
Give me a few moments, just start my production tests :) and already have some corrections. |
Author
|
@lserman tests done. May be this repo needs to setup a CircleCI? It may be more informative when tests was falling red with GH integrations. |
|
@lserman can you merge this ? I also tested on my aws machines and default version gets updated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
create_launch_template_versiondoesn't update default version of launch template. But at logger info we can see:It is not true. I've added this PR to fix it :)