LDEV-5941 improve sessionCommit() add SessionTouch() - 7.0 #2716
+197
−36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| else if ( session instanceof StorageScopeImpl ) { | ||
| ((StorageScopeImpl) session).setDirty(); | ||
| } | ||
| session.touchAfterRequest( pc ); |
Contributor
There was a problem hiding this comment.
to be honest i don't like to call a listener method like "touchAfterRequest" outside the flow it should be called.
this method is called AFTER the request is finished, what if a implementation in the future clean up the request and remove data used by this request, it will then break after this function is executed. at best this limits what this method can do, at worst it corrupts the request.
Contributor
|
do we really need this 2 functions? i think |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://luceeserver.atlassian.net/browse/LDEV-5941