Skip to content

LDEV-5862 fix Bad access to protected data in invokevirtual -v6 #2732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zspitzer wants to merge 2 commits into
base: 6.2
Choose a base branch
from
+61 −3
Open

LDEV-5862 fix Bad access to protected data in invokevirtual -v6 #2732

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
25f24ca
LDEV-5862 fix Bad access to protected data in invokevirtual
zspitzer Dec 12, 2025
4978053
LDEV-5862 fix typo
zspitzer Dec 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 19 additions & 3 deletions core/src/main/java/lucee/transformer/dynamic/meta/dynamic/ClazzDynamic.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,7 @@ public Method getMethod(String methodName, Class[] arguments, boolean nameCaseSe
outer: for (FunctionMember fm: methods) {
if (/* fm.isPublic() && */ (nameCaseSensitive ? methodName.equals(fm.getName()) : methodName.equalsIgnoreCase(fm.getName()))) {
Type[] args = ((FunctionMemberDynamic) fm).getArgumentTypes();
if (types.length == types.length) {
if (types.length == args.length) {
for (int i = 0; i < args.length; i++) {
if (!types[i].equals(args[i])) continue outer;
}
Expand Down Expand Up @@ -493,7 +493,15 @@ public MethodVisitor visitMethod(int access, String name, String descriptor, Str

Type tmpType = tmpClass != null ? Type.getType(tmpClass) : null;
Type rtnType = rtnClass != null ? Type.getType(rtnClass) : null;
if (Clazz.compareAccess(fmParent, fmCurrent) >= 0) fmCurrent.setDeclaringProviderClassWithSameAccess(tmpClass, tmpType, rtnClass, rtnType);
// LDEV-5862: For declaringProviderClassWithSameAccess, use the parent's WithSameAccess version
// to avoid propagating a class where the method has different (e.g., protected) access
if (Clazz.compareAccess(fmParent, fmCurrent) >= 0) {
Class sameAccessClass = fmParent.getDeclaringProviderClassWithSameAccess(true);
Class sameAccessRtnClass = (fmParent instanceof Method) ? fmParent.getDeclaringProviderRtnClassWithSameAccess(true) : null;
Type sameAccessType = sameAccessClass != null ? Type.getType(sameAccessClass) : null;
Type sameAccessRtnType = sameAccessRtnClass != null ? Type.getType(sameAccessRtnClass) : null;
fmCurrent.setDeclaringProviderClassWithSameAccess(sameAccessClass, sameAccessType, sameAccessRtnClass, sameAccessRtnType);
}
fmCurrent.setDeclaringProviderClass(tmpClass, tmpType, rtnClass, rtnType);
/*
* if (name.equals("nextElement")) { print.e(fm.getDeclaringProviderClassName());
Expand Down Expand Up @@ -640,7 +648,15 @@ public MethodVisitor visitMethod(int access, String name, String descriptor, Str
Type tmpType = tmpClass != null ? Type.getType(tmpClass) : null;
Type rtnType = rtnClass != null ? Type.getType(rtnClass) : null;

if (Clazz.compareAccess(fmParent, fmCurrent) >= 0) fmCurrent.setDeclaringProviderClassWithSameAccess(tmpClass, tmpType, rtnClass, rtnType);
// LDEV-5862: For declaringProviderClassWithSameAccess, use the parent's WithSameAccess version
// to avoid propagating a class where the method has different (e.g., protected) access
if (Clazz.compareAccess(fmParent, fmCurrent) >= 0) {
Class sameAccessClass = fmParent.getDeclaringProviderClassWithSameAccess(true);
Class sameAccessRtnClass = (fmParent instanceof Method) ? fmParent.getDeclaringProviderRtnClassWithSameAccess(true) : null;
Type sameAccessType = sameAccessClass != null ? Type.getType(sameAccessClass) : null;
Type sameAccessRtnType = sameAccessRtnClass != null ? Type.getType(sameAccessRtnClass) : null;
fmCurrent.setDeclaringProviderClassWithSameAccess(sameAccessClass, sameAccessType, sameAccessRtnClass, sameAccessRtnType);
}
fmCurrent.setDeclaringProviderClass(tmpClass, tmpType, rtnClass, rtnType);

/*
Expand Down
42 changes: 42 additions & 0 deletions test/tickets/LDEV5862.cfc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
component extends="org.lucee.cfml.test.LuceeTestCase" {

function run( testResults, testBox ) {
describe( title='LDEV-5862 Bad access to protected data in invokevirtual', body=function() {

it( title='clone() on HashMap', body=function() {
var map = createObject( "java", "java.util.HashMap" ).init();
map.put( "key", "value" );
var cloned = map.clone();
expect( cloned.get( "key" ) ).toBe( "value" );
});

it( title='clone() on LinkedHashMap', body=function() {
var map = createObject( "java", "java.util.LinkedHashMap" ).init();
map.put( "key", "value" );
var cloned = map.clone();
expect( cloned.get( "key" ) ).toBe( "value" );
});

it( title='clone() on ArrayList', body=function() {
var list = createObject( "java", "java.util.ArrayList" ).init();
list.add( "item" );
var cloned = list.clone();
expect( cloned.get( 0 ) ).toBe( "item" );
});

it( title='clone() on SimpleDateFormat', body=function() {
var sdf = createObject( "java", "java.text.SimpleDateFormat" ).init( "yyyy-MM-dd" );
var cloned = sdf.clone();
expect( cloned.toPattern() ).toBe( "yyyy-MM-dd" );
});

it( title='clone() on Date', body=function() {
var d = createObject( "java", "java.util.Date" ).init();
var cloned = d.clone();
expect( cloned.getTime() ).toBe( d.getTime() );
});

});
}

}