Integration Test - Preference #27
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brunacamposxx
requested review from
delias-silva,
edmarSoaress,
eltinMeli,
lucmantovani,
lucmkz,
rhames07,
romerosilva and
taliyada
e2e/payments/cancel.spec.ts
Outdated
| const payment = await create(paymentBody); | ||
| expect(payment).toHaveProperty('id'); | ||
|
|
||
| const cancelation = await cancel({ id: String(payment.id), config : client }); |
Collaborator
There was a problem hiding this comment.
Seria interessante modificarmos o tipo do parâmetro da função cancel para receber um id numérico?
Falo isso por 2 pontos:
- Consistência entre tipos das entidades e das funções
- Tirar a responsabilidade do integrador de ficar fazendo essas conversões
Isso pelo menos na camada externa, e fazemos as conversões necessárias internamente
Collaborator
Author
There was a problem hiding this comment.
Feito na branch de Payments ✅
Co-authored-by: Lucas Mantovani <[email protected]>
refactor gitflow
…import-mpconfig added names export for mercadopago module
…ue-typo typo worflows to workflows
rename module MercadoPago to MercadoPagoConfig
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
✅ Checklist:
🧰 How to reproduce
📸 Screenshots
📄 References