Skip to content

Conversation

@ychsiao168
Copy link

@ychsiao168 ychsiao168 commented Nov 7, 2025

  • Remove hardcoded STATIC from add_library() to respect BUILD_SHARED_LIBS
  • Adjust wayland-scanner to use public-code for shared libs, private-code for static
  • Fix lvglsim linking by repeating lvgl_linux to resolve circular dependency
  • Add LIBRARY destination to install() for shared library support"

Tested on WSL:

  • ✅ Shared build (-DBUILD_SHARED_LIBS=ON)
  • ✅ Static build (-DBUILD_SHARED_LIBS=OFF)
  • ✅ Both lvglsim executables run correctly
  • make install works for both configurations

Summary by cubic

Add shared library support to lvgl_linux by respecting BUILD_SHARED_LIBS. Updates Wayland protocol generation and lvglsim linking so both shared and static builds compile and install cleanly.

  • New Features

    • Library type now follows BUILD_SHARED_LIBS (removed hardcoded STATIC).
    • wayland-scanner uses public-code for shared, private-code for static.
    • lvglsim links lvgl_linux, lvgl, lvgl_linux to resolve circular dependency.
    • Added LIBRARY DESTINATION to install(TARGETS) for shared library installs.
  • Migration

    • Build with -DBUILD_SHARED_LIBS=ON for shared, OFF for static; no other changes.

Written for commit bcb93ab. Summary will update automatically on new commits.

- Remove hardcoded STATIC from add_library() to respect BUILD_SHARED_LIBS
- Adjust wayland-scanner to use public-code for shared libs, private-code for static
- Fix lvglsim linking by repeating lvgl_linux to resolve circular dependency
- Add LIBRARY destination to install() for shared library support"
Copy link

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant