-
Notifications
You must be signed in to change notification settings - Fork 241
Feature Request:GBase8s DB #258 add support GBase8s DB #267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Feature Request:GBase8s DB madelson#258 add support GBase8s DB
| <Using Remove="System.Net.Http" /> | ||
| </ItemGroup> | ||
| <ItemGroup> | ||
| <Content Include="..\..\..\..\GeneralData.EntityFrameworkCore.GBase.DataProvider.dll" PackagePath="lib\netstandard2.1"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should not be included
| </PropertyGroup> | ||
|
|
||
| <ItemGroup> | ||
| <PackageReference Include="GeneralData.GBase8s.DataProvider" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove
| <CentralPackageTransitivePinningEnabled>true</CentralPackageTransitivePinningEnabled> | ||
| </PropertyGroup> | ||
| <ItemGroup> | ||
| <PackageVersion Include="GeneralData.GBase8s.DataProvider" Version="1.0.0.1" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This library isn't well-established enough for use here (< 1K downloads, < 2 months old).
Looks like Odbc seems to be the more common pattern for GBase interactions in the NuGet world
| Console.WriteLine(ex.StackTrace); | ||
| foreach (GbsError err in ((GbsException)ex).Errors) | ||
| { | ||
| Console.WriteLine("Native Error" + err.NativeError); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove all Console logs
Overview:
This PR adds support for the GBase8s database.
Key Changes:
Added the GBase8s dialect directory, and the framework has also incorporated the processing procedures for GBase8s.
Related Issue: #258.
Components required for the Windows:
https://www.gbase.cn/download/gbase-8s-1?category=DRIVER_PACKAGE
download:clientsdk_3.6.3_3X3_1_ee39df_WIN2003_x86_32.ZIP
Checklist:
Local tests passed.
No breaking changes identified.