Skip to content

S2.UI.Accordion does not hide content on initialization #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Korkonius wants to merge 3 commits into
base: master
Choose a base branch
from
Open

S2.UI.Accordion does not hide content on initialization #25

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f60ea86
Modified accordion to have a default index
Mar 4, 2011
e05e3d6
Added defaultIndex option to S2.UI.Accordion and fixed initialization…
Mar 4, 2011
a484c0f
Merge branch 'master' of github.com:Korkonius/scripty2
Korkonius Mar 6, 2011
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions src/ui/controls/accordion.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,9 @@ Object.extend(Event, {
* Applies "accordion menu" behavior to an element and its contents.
*
* ##### Options
*
*
* * `defaultIndex` (Integer): Determines which content element should be
* open by default.
* * `multiple` (Boolean): Whether multiple panels can be open at once.
* Defaults to `false`.
* * `headerSelector` (String): A CSS selector that identifies the
Expand Down Expand Up @@ -68,9 +70,13 @@ Object.extend(Event, {
header.insert({ top: icon });
});

// If the user specified an active header, mark it as active.
// If the user specified a default index, mark it as active.
// Otherwise, the first one is active by default.
this._markActive(opt.active || this.headers.first(), false);
this.content.each(function(element, i){
if(opt.defaultIndex != i) {
element.hide();
}
});

// ARIA.
this.element.writeAttribute({
Expand Down Expand Up @@ -223,6 +229,7 @@ Object.extend(Event, {

Object.extend(UI.Accordion, {
DEFAULT_OPTIONS: {
defaultIndex: 0,
multiple: false, /* whether more than one pane can be open at once */
headerSelector: 'h3',

Expand Down