samples(storagecontrol): add samples for anywhere cache #18

mahendra-google · 2025-07-28T12:36:19Z

This internal PR adds sample code for the anywhere cache feature, allowing users to:

Canonical PR used as a guide :- PR

Note

Sample tests are not included because of the long operation time.

samples(storage): add sample for create anywhere cache samples(storage): add samples for anywhere cache samples(storage): add sample to create anywhere cache samples(storage): add sample to disable anywhere cahce

mahendra-google · 2025-08-21T12:22:41Z

/gemini review

gemini-code-assist

Code Review

This pull request adds new samples for Storage Control Anywhere Cache and Model Armor features, along with corresponding tests. The changes are generally well-implemented. I've identified a couple of areas for improvement in the test files: one regarding resource cleanup in a test, which could lead to resource leaks, and another concerning code duplication in another test. Addressing these points will improve the robustness and maintainability of the test suite.

modelarmor/api/ModelArmor.Samples.Tests/QuickStartTest.cs

modelarmor/api/ModelArmor.Samples.Tests/CreateTemplateWithLabelsTest.cs

mahendra-google · 2025-08-21T12:28:15Z

/gemini summary

gemini-code-assist · 2025-08-21T12:28:36Z

Summary of Changes

This pull request introduces a comprehensive set of C# sample code for managing Google Cloud Storage's new "anywhere cache" feature, demonstrating how to create, retrieve, list, update, pause, disable, and resume anywhere cache instances. Additionally, it includes new samples and tests for Google Cloud Model Armor, focusing on template creation with labels and metadata, providing practical examples for developers to integrate these functionalities into their applications.

Highlights

Google Cloud Storage Control Anywhere Cache Samples: New C# samples have been added for Google Cloud Storage Control's "anywhere cache" feature, covering essential lifecycle operations such as creation, retrieval, listing, updating, pausing, disabling, and resuming cache instances.
Google Cloud Model Armor Samples and Tests: This PR introduces new C# samples and corresponding tests for Google Cloud Model Armor, specifically demonstrating how to create templates with custom labels and metadata.
Model Armor Test Cleanup: A minor cleanup was performed in an existing Model Armor quickstart test, removing a redundant resource cleanup registration to improve test efficiency and prevent potential resource leaks.

Changelog

modelarmor/api/ModelArmor.Samples.Tests/CreateTemplateTest.cs
- Added a new test for creating a Model Armor template with predefined RAI filter settings.
modelarmor/api/ModelArmor.Samples.Tests/CreateTemplateWithLabelsTest.cs
- Added a new test to verify the creation of a Model Armor template with custom labels.
modelarmor/api/ModelArmor.Samples.Tests/CreateTemplateWithMetadataTest.cs
- Added a new test to confirm the creation of a Model Armor template with specific metadata settings.
modelarmor/api/ModelArmor.Samples.Tests/QuickStartTest.cs
- Modified to remove a redundant call to _fixture.RegisterTemplateForCleanup, streamlining the test setup.
modelarmor/api/ModelArmor.Samples/CreateTemplateWithLabels.cs
- Added a new sample demonstrating how to create a Model Armor template with user-defined labels.
modelarmor/api/ModelArmor.Samples/CreateTemplateWithMetadata.cs
- Added a new sample illustrating the creation of a Model Armor template with custom metadata.
modelarmor/api/ModelArmor.Samples/ModelArmor.Samples.csproj
- Minor modification to the project file, likely a formatting fix (removed a BOM character).
storage/api/README.md
- Minor formatting adjustment, specifically removing a newline character at the end of the file.
storage/api/Storage.Samples/StorageControlCreateAnywhereCache.cs
- Added a new sample for creating an anywhere cache instance within a specified bucket and zone.
storage/api/Storage.Samples/StorageControlDisableAnywhereCache.cs
- Added a new sample for disabling an existing anywhere cache instance.
storage/api/Storage.Samples/StorageControlGetAnywhereCache.cs
- Added a new sample for retrieving details of a specific anywhere cache instance.
storage/api/Storage.Samples/StorageControlListAnywhereCaches.cs
- Added a new sample for listing all anywhere cache instances associated with a given bucket.
storage/api/Storage.Samples/StorageControlPauseAnywhereCache.cs
- Added a new sample for pausing an active anywhere cache instance.
storage/api/Storage.Samples/StorageControlResumeAnywhereCache.cs
- Added a new sample for resuming a previously disabled or paused anywhere cache instance.
storage/api/Storage.Samples/StorageControlUpdateAnywhereCache.cs
- Added a new sample for updating the admission policy of an anywhere cache instance.

Activity

mahendra-google initiated a review of the pull request.
gemini-code-assist[bot] provided a high-priority comment regarding potential resource leaks in modelarmor/api/ModelArmor.Samples.Tests/QuickStartTest.cs due to a removed cleanup registration.
gemini-code-assist[bot] provided a medium-priority comment suggesting code simplification in modelarmor/api/ModelArmor.Samples.Tests/CreateTemplateWithLabelsTest.cs by reusing an existing client instance.
mahendra-google requested a summary of the pull request.

mahendra-google · 2025-08-21T12:33:03Z

/Gemini help

gemini-code-assist · 2025-08-21T12:33:06Z

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

mahendra-google · 2025-09-04T12:08:55Z

/Gemini review

gemini-code-assist

Code Review

This pull request introduces new samples and corresponding tests for the Model Armor and Storage Control APIs, specifically for the 'anywhere cache' feature. The changes are well-structured and cover the intended functionality. I've provided a few suggestions to improve code consistency, readability, and adherence to best practices, such as using collection initializers, reusing test fixture resources, ensuring consistent namespacing, and correcting license header formatting.

modelarmor/api/ModelArmor.Samples.Tests/CreateTemplateWithLabelsTest.cs

modelarmor/api/ModelArmor.Samples/CreateTemplateWithLabels.cs

modelarmor/api/ModelArmor.Samples/CreateTemplateWithMetadata.cs

storage/api/Storage.Samples/StorageControlCreateAnywhereCache.cs

This reverts commit 966586a.

mahendra-google · 2025-09-08T08:09:38Z

/Gemini review

gemini-code-assist

Code Review

This pull request adds new samples for Storage Control's Anywhere Cache feature and also includes new samples and tests for Model Armor. My review focuses on improving code consistency, fixing potential bugs, and addressing style issues. Key points include correcting a potential resource leak in a test, fixing an incorrect property name that would cause a compilation error, and improving consistency across sample files. I've also noted some minor issues in the license headers and documentation.

modelarmor/api/ModelArmor.Samples.Tests/QuickStartTest.cs

storage/api/Storage.Samples/StorageControlCreateAnywhereCache.cs

modelarmor/api/ModelArmor.Samples.Tests/CreateTemplateWithLabelsTest.cs

modelarmor/api/ModelArmor.Samples.Tests/CreateTemplateWithMetadataTest.cs

modelarmor/api/ModelArmor.Samples/CreateTemplateWithLabels.cs

storage/api/README.md

storage/api/Storage.Samples/StorageControlCreateAnywhereCache.cs

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

storage/api/Storage.Samples/StorageControlGetAnywhereCache.cs

storage/api/Storage.Samples/StorageControlPauseAnywhereCache.cs

storage/api/Storage.Samples/StorageControlResumeAnywhereCache.cs

storage/api/README.md

gurusai-voleti · 2025-09-08T13:42:13Z

@mahendra-google why those modelarmor files are needed in this PR

mahendra-google · 2025-09-09T08:32:55Z

@mahendra-google why those modelarmor files are needed in this PR

This pull request does not include any Model Armor code changes. I rebased the branch to sync with the latest upstream changes and prevent merge conflicts

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

storage/api/README.md

…ni code review

thiyaguk09

I’ve added a few comments—please address them. Otherwise, everything looks good to me.

storage/api/Storage.Samples/StorageControlCreateAnywhereCache.cs

storage/api/Storage.Samples/StorageControlDisableAnywhereCache.cs

storage/api/Storage.Samples/StorageControlGetAnywhereCache.cs

storage/api/Storage.Samples/StorageControlPauseAnywhereCache.cs

storage/api/Storage.Samples/StorageControlResumeAnywhereCache.cs

storage/api/Storage.Samples/StorageControlUpdateAnywhereCache.cs

…torageControlCreateAnywhereCache.cs

…eid in samples

thiyaguk09

LGTM

mahendra-google force-pushed the anywhere_cache_storage_control branch 4 times, most recently from ed7ce6d to 7d2e947 Compare July 31, 2025 13:21

samples(storage control): add samples for anywhere cache

ca82d74

samples(storage): add sample for create anywhere cache samples(storage): add samples for anywhere cache samples(storage): add sample to create anywhere cache samples(storage): add sample to disable anywhere cahce

mahendra-google force-pushed the anywhere_cache_storage_control branch from 6603ae8 to ca82d74 Compare August 6, 2025 05:26

mahendra-google and others added 4 commits August 6, 2025 04:02

samples(storage): modify sample to create anywhere cache

cbd60f6

samples(storage): modify default bucket name

36bb43b

samples(storage): add samples to update anyhere cache

b435193

samples(storage): Remove unused assembly reference

9356839

mahendra-google marked this pull request as ready for review August 21, 2025 05:00

gemini-code-assist bot reviewed Aug 21, 2025

View reviewed changes

modelarmor/api/ModelArmor.Samples.Tests/QuickStartTest.cs Outdated Show resolved Hide resolved

modelarmor/api/ModelArmor.Samples.Tests/CreateTemplateWithLabelsTest.cs Outdated Show resolved Hide resolved

mahendra-google added 2 commits September 4, 2025 03:03

samples(storage): add test to list anywhere cache

966586a

samples(storage); add tests for anywhere cache

963ed6c

mahendra-google changed the title ~~samples(storage control): add samples for anywhere cache~~ samples(storage control): add samples and test cases for anywhere cache Sep 4, 2025

gemini-code-assist bot reviewed Sep 4, 2025

View reviewed changes

mahendra-google added 3 commits September 4, 2025 05:25

samples(storage): remove unused namespace

bbbdfc7

Revert test Code

20e8e08

Revert "samples(storage): add test to list anywhere cache"

311d8e1

This reverts commit 966586a.

mahendra-google changed the title ~~samples(storage control): add samples and test cases for anywhere cache~~ samples(storage control): add samples for anywhere cache Sep 8, 2025

Update README.md

5f00e7d

mahendra-google requested review from gurusai-voleti, shubhangi-google and thiyaguk09 September 8, 2025 08:09

gemini-code-assist bot reviewed Sep 8, 2025

View reviewed changes

Update storage/api/README.md

0a1272e

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

gurusai-voleti reviewed Sep 8, 2025

View reviewed changes

storage/api/Storage.Samples/StorageControlGetAnywhereCache.cs Show resolved Hide resolved

gurusai-voleti reviewed Sep 8, 2025

View reviewed changes

storage/api/Storage.Samples/StorageControlPauseAnywhereCache.cs Show resolved Hide resolved

gurusai-voleti reviewed Sep 8, 2025

View reviewed changes

storage/api/Storage.Samples/StorageControlResumeAnywhereCache.cs Show resolved Hide resolved

gurusai-voleti reviewed Sep 8, 2025

View reviewed changes

storage/api/README.md Outdated Show resolved Hide resolved

mahendra-google and others added 3 commits September 9, 2025 04:11

samples(storage control): modify parameter name in sample methods

18f2f68

Update storage/api/Storage.Samples/StorageControlCreateAnywhereCache.cs

d9c95d7

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

Update README.md

a1753a1

mahendra-google changed the title ~~samples(storage control): add samples for anywhere cache~~ samples(storagecontrol): add samples for anywhere cache Sep 10, 2025

gurusai-voleti reviewed Sep 10, 2025

View reviewed changes

storage/api/README.md Show resolved Hide resolved

samples(storagecontrol): remove trailing whitespaces from google gemi…

352f782

…ni code review

thiyaguk09 requested changes Sep 11, 2025

View reviewed changes

mahendra-google added 2 commits September 11, 2025 19:41

samples(storagecontrol): modify zoneName default parameter value in S…

6d27cf4

…torageControlCreateAnywhereCache.cs

samples(storagecontrol): modify parameter name for samples

07b9318

mahendra-google requested a review from thiyaguk09 September 15, 2025 06:05

samples(storagecontrol): modify parameter description of anywherecach…

a07f19d

…eid in samples

thiyaguk09 approved these changes Sep 15, 2025

View reviewed changes

mahendra-google added 5 commits September 15, 2025 00:22

samples(storagecontrol): undo changes

46de3ed

Update README.md

27d3e9c

Delete modelarmor/api/ModelArmor.Samples/ModelArmor.Samples.csproj

6755e78

samples(ModelArmer): add project file

da18d89

Update ModelArmor.Samples.csproj

2aa5893

samples(storagecontrol): add samples for anywhere cache #18

Are you sure you want to change the base?

samples(storagecontrol): add samples for anywhere cache #18

Uh oh!

Conversation

mahendra-google commented Jul 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mahendra-google commented Aug 21, 2025

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

mahendra-google commented Aug 21, 2025

Uh oh!

gemini-code-assist bot commented Aug 21, 2025

Summary of Changes

Highlights

Uh oh!

mahendra-google commented Aug 21, 2025

Uh oh!

gemini-code-assist bot commented Aug 21, 2025

Uh oh!

mahendra-google commented Sep 4, 2025

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mahendra-google commented Sep 8, 2025

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gurusai-voleti commented Sep 8, 2025

Uh oh!

mahendra-google commented Sep 9, 2025

Uh oh!

Uh oh!

thiyaguk09 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

thiyaguk09 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

mahendra-google commented Jul 28, 2025 •

edited

Loading