samples(storage transfer): add samples and test cases for storage transfer services #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…transfer_transfer_to_nearline.
…b.com/mahendra-google/dotnet-docs-samples into missing_.net_transfer_service_samples
…storagetransfer_transfer_to_nearline.
…or storagetransfer_transfer_to_nearline.
…b.com/mahendra-google/dotnet-docs-samples into missing_.net_transfer_service_samples
…utput message in sample output and related small changes.
…andard output of test log summary.
…test transfer operation.
…sfer to nearline and check latest transfer operation (#1)
…ket using manifest file (#2)
… folder in posix file system (#5)
…ole , rewording , removing some unnecessary symbols, few test checks removed related to posix file transfer.
…estSample.cs Co-authored-by: Amanda Tarafa Mas <[email protected]>
…gManifestTest.cs Co-authored-by: Amanda Tarafa Mas <[email protected]>
amrik-mahal
reviewed
Mar 20, 2025
storagetransfer/api/StorageTransfer.Samples.Tests/CheckLatestTransferOperationTest.cs
Show resolved
Hide resolved
amrik-mahal
requested changes
Mar 20, 2025
Collaborator
amrik-mahal
left a comment
amrik-mahal
left a comment
There was a problem hiding this comment.
Looks good. overall feedback to include comment in the tests. single line comment for whole file is also fine.
Owner
Author
|
@amrik-mahal This PR is ready for re-review |
Owner
Author
|
amrik-mahal
approved these changes
Apr 17, 2025
Collaborator
amrik-mahal
left a comment
amrik-mahal
left a comment
There was a problem hiding this comment.
Reviewed looks good to go.
We were parsing the string to a DateTime before anyway.
…er manager quickstart (GoogleCloudPlatform#2986)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding samples and tests cases for following storage transfer services: