-
Notifications
You must be signed in to change notification settings - Fork 2.8k
[WEB-5191 | WEB-5197] chore: actions and arrows icon revamp #7984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Linked to Plane Work Item(s) References This comment was auto-generated by Plane |
|
Important Review skippedMore than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review. 91 files out of 198 files are above the max files limit of 100. Please upgrade to Pro plan to get higher limits. You can disable this status message by setting the Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Migrates several UI icons from lucide-react to the in-house Propel icon set and introduces a centralized icon system.
- Adds IconWrapper and a typed Icon registry for consistent icon usage across the app.
- Replaces lucide X and other icons with Propel equivalents throughout components and stories.
- Introduces new icon groups (workspace, project, properties, layouts, sub-brand) and updates exports and stories.
Reviewed Changes
Copilot reviewed 220 out of 220 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/propel/src/toast/toast.tsx | Replaced lucide X with CloseIcon in toast close buttons. |
| packages/propel/src/popover/popover.stories.tsx | Replaced lucide X with CloseIcon in story. |
| packages/propel/src/icons/workspace/your-work-icon.tsx | Migrated to IconWrapper and updated imports. |
| packages/propel/src/icons/workspace/project-icon.tsx | Migrated to IconWrapper and updated imports. |
| packages/propel/src/icons/workspace/index.ts | New index exporting workspace icons. |
| packages/propel/src/icons/workspace/inbox-icon.tsx | Migrated to IconWrapper and updated imports. |
| packages/propel/src/icons/workspace/home-icon.tsx | Migrated to IconWrapper and updated imports. |
| packages/propel/src/icons/workspace/draft-icon.tsx | Migrated to IconWrapper and updated imports. |
| packages/propel/src/icons/workspace/dashboard-icon.tsx | Migrated to IconWrapper and updated imports. |
| packages/propel/src/icons/workspace/archive-icon.tsx | Migrated to IconWrapper and updated imports. |
| packages/propel/src/icons/workspace/analytics-icon.tsx | Migrated to IconWrapper and updated imports. |
| packages/propel/src/icons/work-items-icon.tsx | Removed deprecated top-level WorkItemsIcon; moved under project. |
| packages/propel/src/icons/wiki-icon.tsx | Removed deprecated top-level WikiIcon; moved under sub-brand. |
| packages/propel/src/icons/view-icon.tsx | Removed deprecated top-level View icon; moved under project. |
| packages/propel/src/icons/sub-brand/wiki-icon.tsx | New sub-brand WikiIcon using IconWrapper. |
| packages/propel/src/icons/sub-brand/plane-icon.tsx | New sub-brand PlaneNewIcon using IconWrapper. |
| packages/propel/src/icons/sub-brand/pi-chat.tsx | Updated PiChatLogo to IconWrapper with 24x24 viewBox. |
| packages/propel/src/icons/sub-brand/index.ts | New index exporting sub-brand icons. |
| packages/propel/src/icons/registry.ts | Introduces ICON_REGISTRY mapping string names to icon components. |
| packages/propel/src/icons/properties/workflows-icon.tsx | New property icon. |
| packages/propel/src/icons/properties/user-square-icon.tsx | New property icon. |
| packages/propel/src/icons/properties/user-icon.tsx | New property icon. |
| packages/propel/src/icons/properties/user-circle-icon.tsx | New property icon. |
| packages/propel/src/icons/properties/state-icon.tsx | New property icon. |
| packages/propel/src/icons/properties/start-date-icon.tsx | New property icon. |
| packages/propel/src/icons/properties/scrope-icon.tsx | New property icon (filename has a typo). |
| packages/propel/src/icons/properties/relation-icon.tsx | New property icon. |
| packages/propel/src/icons/properties/relates-to-icon.tsx | New property icon. |
| packages/propel/src/icons/properties/priority-icon.tsx | New property icon. |
| packages/propel/src/icons/properties/parent-icon.tsx | New property icon. |
| packages/propel/src/icons/properties/overdue-date-icon.tsx | New property icon. |
| packages/propel/src/icons/properties/members-icon.tsx | New property icon. |
| packages/propel/src/icons/properties/label-icon.tsx | New property icon. |
| packages/propel/src/icons/properties/index.ts | New index exporting property icons (contains a typo in one export path). |
| packages/propel/src/icons/properties/hash-icon.tsx | New property icon. |
| packages/propel/src/icons/properties/estimate-icon.tsx | New property icon. |
| packages/propel/src/icons/properties/duplicate-icon.tsx | New property icon. |
| packages/propel/src/icons/properties/due-date-icon.tsx | New property icon. |
| packages/propel/src/icons/properties/dropdown-icon.tsx | New property icon. |
| packages/propel/src/icons/properties/boolean-icon.tsx | New property icon. |
| packages/propel/src/icons/project/work-items-icon.tsx | New project icon. |
| packages/propel/src/icons/project/view-icon.tsx | New project icon. |
| packages/propel/src/icons/project/page-icon.tsx | Updated Page icon to use IconWrapper. |
| packages/propel/src/icons/project/module-icon.tsx | Updated Module icon to use IconWrapper. |
| packages/propel/src/icons/project/intake-icon.tsx | New project Intake icon (moved from top-level). |
| packages/propel/src/icons/project/index.ts | New index exporting project icons. |
| packages/propel/src/icons/project/epic-icon.tsx | New project icon. |
| packages/propel/src/icons/project/cycle-icon.tsx | New project icon. |
| packages/propel/src/icons/plane-icon.tsx | Removed deprecated top-level Plane icon. |
| packages/propel/src/icons/layouts/timeline-icon.tsx | New layout icon. |
| packages/propel/src/icons/layouts/sheet-icon.tsx | New layout icon. |
| packages/propel/src/icons/layouts/list-icon.tsx | New layout icon. |
| packages/propel/src/icons/layouts/index.ts | New index exporting layout icons. |
| packages/propel/src/icons/layouts/grid-icon.tsx | New layout icon. |
| packages/propel/src/icons/layouts/card-icon.tsx | New layout icon. |
| packages/propel/src/icons/layouts/calendar-icon.tsx | New layout icon. |
| packages/propel/src/icons/layouts/board-icon.tsx | New layout icon. |
| packages/propel/src/icons/intake-icon.tsx | Removed deprecated top-level Intake icon. |
| packages/propel/src/icons/index.ts | Refactored exports to new grouped structure and registry. |
| packages/propel/src/icons/icons.stories.tsx | New Stories covering registry-based and direct icon usage. |
| packages/propel/src/icons/icon.tsx | New Icon component resolving icons by registry name. |
| packages/propel/src/icons/icon-wrapper.tsx | New IconWrapper providing common SVG scaffolding. |
| packages/propel/src/icons/helpers.ts | Helpers for working with the icon registry. |
| packages/propel/src/icons/epic-icon.tsx | Removed deprecated top-level Epic icon. |
| packages/propel/src/icons/default-icon.tsx | New default/fallback icon. |
| packages/propel/src/icons/cycle/cycle-group-icon.tsx | Updated import path to new project CycleIcon. |
| packages/propel/src/icons/cycle-icon.tsx | Removed deprecated top-level Cycle icon. |
| packages/propel/src/icons/constants.tsx | Storybook icon maps for gallery/demo. |
| packages/propel/src/icons/add-icon.tsx | Removed deprecated top-level Add icon; replaced with actions/add-icon. |
| packages/propel/src/icons/actions/index.ts | New actions icon index. |
| packages/propel/src/icons/actions/close-icon.tsx | New CloseIcon. |
| packages/propel/src/icons/actions/add-icon.tsx | New AddIcon. |
| packages/propel/src/dialog/dialog.stories.tsx | Replaced lucide X with CloseIcon in stories. |
| packages/editor/.../row/dropdown.tsx | Removed unused lucide X import. |
| packages/editor/.../column/dropdown.tsx | Removed unused lucide X import. |
| packages/editor/.../full-screen/modal.tsx | Replaced lucide X with CloseIcon. |
| packages/constants/src/issue/common.ts | Updated spreadsheet property icon keys to Propel icon names. |
| apps/web/.../workspace/invite-modal/fields.tsx | Replaced lucide X with CloseIcon. |
| apps/web/.../workspace-notifications/.../snooze/modal.tsx | Replaced lucide X with CloseIcon. |
| apps/web/.../workspace-notifications/.../applied-filter.tsx | Replaced lucide X with CloseIcon. |
| apps/web/.../views/view-list-header.tsx | Replaced lucide X with CloseIcon. |
| apps/web/.../views/filters/filter-selection.tsx | Replaced lucide X with CloseIcon (one usage uses unsupported size prop). |
| apps/web/.../views/applied-filters/root.tsx | Replaced lucide X with CloseIcon. |
| apps/web/.../views/applied-filters/access.tsx | Replaced lucide X with CloseIcon. |
| apps/web/.../stickies/modal/stickies.tsx | Replaced lucide X with CloseIcon. |
| apps/web/.../stickies/modal/search.tsx | Replaced lucide X with CloseIcon. |
| apps/web/.../stickies/action-bar.tsx | Replaced lucide X with CloseIcon. |
| apps/web/.../rich-filters/filter-item/close-button.tsx | Replaced lucide X with CloseIcon. |
| apps/web/.../readonly/estimate.tsx | Replaced lucide Triangle with EstimatePropertyIcon. |
| apps/web/.../project/send-project-invitation-modal.tsx | Replaced lucide X with CloseIcon. |
| apps/web/.../project/search-projects.tsx | Replaced lucide X with CloseIcon. |
| apps/web/.../project/multi-select-modal.tsx | Replaced lucide X with CloseIcon. |
| apps/web/.../project/dropdowns/filters/root.tsx | Replaced lucide X with CloseIcon. |
| apps/web/.../project/create/header.tsx | Replaced lucide X with CloseIcon. |
| apps/web/.../project/applied-filters/root.tsx | Replaced lucide X with CloseIcon. |
| apps/web/.../project/applied-filters/project-display-filters.tsx | Replaced lucide X with CloseIcon. |
| apps/web/.../project/applied-filters/members.tsx | Replaced lucide X with CloseIcon. |
| apps/web/.../project/applied-filters/date.tsx | Replaced lucide X with CloseIcon. |
| apps/web/.../project/applied-filters/access.tsx | Replaced lucide X with CloseIcon. |
| apps/web/.../project-states/options/delete.tsx | Replaced lucide X with CloseIcon. |
| apps/web/.../profile/overview/stats.tsx | Replaced lucide UserCircle2 with UserCirclePropertyIcon. |
| apps/web/.../pages/list/search-input.tsx | Replaced lucide X with CloseIcon. |
| apps/web/.../pages/list/filters/root.tsx | Replaced lucide X with CloseIcon. |
| apps/web/.../pages/list/applied-filters/root.tsx | Replaced lucide X with CloseIcon. |
| apps/web/.../onboarding/tour/root.tsx | Replaced lucide X with CloseIcon. |
| apps/web/.../modules/sidebar-select/select-status.tsx | Replaced DoubleCircleIcon with StatePropertyIcon. |
| apps/web/.../modules/applied-filters/members.tsx | Replaced lucide X with CloseIcon. |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
…ns-and-arrows-icon-revamp
…ns-and-arrows-icon-revamp
…ns-and-arrows-icon-revamp
Description
This PR includes following changes:
Actions icon: (lucide-react -> Propel)
Arrows icon: (lucide-react -> Propel)
Type of Change