Skip to content

Fix input reverse autocomplete behavior #257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
malwoodsantoro wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix input reverse autocomplete behavior #257

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
08d0d4a
fix input reverse autocomplete behavior
malwoodsantoro Aug 4, 2020
4c195f0
add focus indicator
malwoodsantoro Aug 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions src/actions/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,10 +244,6 @@ export function reverse() {
if (state.destination.geometry) dispatch(originPoint(state.destination.geometry.coordinates));
if (state.origin.geometry) dispatch(destinationPoint(state.origin.geometry.coordinates));
if (state.origin.geometry && state.destination.geometry) dispatch(fetchDirections());
const suggestions = document.getElementsByClassName('suggestions');
for (var i = 0; i < suggestions.length; i++) {
suggestions[i].style.visibility = 'hidden';
};
};
}

Expand Down
22 changes: 19 additions & 3 deletions src/controls/inputs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,9 +108,25 @@ export default class Inputs {
this.container
.querySelector('.js-reverse-inputs')
.addEventListener('click', () => {
const { origin, destination } = this.store.getState();
if (origin) this.actions.queryDestination(origin.geometry.coordinates);
if (destination) this.actions.queryOrigin(destination.geometry.coordinates);

var originValue = document.getElementById('mapbox-directions-origin-input').querySelector('input').value;
var destinationValue = document.getElementById('mapbox-directions-destination-input').querySelector('input').value;

//var originSuggestions = document.getElementById('mapbox-directions-origin-input').getElementsByClassName('suggestions')
//var destinationSuggestions = document.getElementById('mapbox-directions-destination-input').getElementsByClassName('suggestions')

if (originValue && destinationValue) {
this.originInput.setInput(destinationValue);
this.destinationInput.setInput(originValue);
} else if (originValue && !destinationValue) {
document.getElementById('mapbox-directions-origin-input').querySelector('input').value = "";
document.getElementById('mapbox-directions-destination-input').querySelector('input').focus()
this.destinationInput.setInput(originValue);
} else if (destinationValue && !originValue) {
document.getElementById('mapbox-directions-destination-input').querySelector('input').value = "";
document.getElementById('mapbox-directions-origin-input').querySelector('input').focus()
this.originInput.setInput(destinationValue);
}
reverse();
});
}
Expand Down