This repository was archived by the owner on Apr 24, 2024. It is now read-only.
support limit parameter in geocoder#1258
Open
tomap wants to merge 3 commits intomapbox:publisher-productionfrom
Open
support limit parameter in geocoder#1258tomap wants to merge 3 commits intomapbox:publisher-productionfrom
tomap wants to merge 3 commits intomapbox:publisher-productionfrom
Conversation
Author
|
Hey, you published a new version recently, could you look at the PR? |
…creaseGeocoderLimit
…creaseGeocoderLimit
|
Thanks for flagging this, @tomap. As far as I can tell this looks like a pretty straightforward change, but before we approve/merge would you mind doing the following two things:
|
Author
|
4 years later, would you mind doing it? I did half the job. I would be very glad if you did the rest of the job :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
geocoder api supports between 1 and 10 search results. Default value is 5.
Now, it's possible to set the limit