On a flyTo call with prefers-reduced-motion set, apply the padding option #6593
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manuel-em
changed the title
…s-reduced-motion is set and flyTo calls a jumpTo instead
manuel-em
force-pushed
the
6576-prefersReducedMotion-padding
branch
from
7b66867 to
a356d67
Compare
manuel-em
changed the title
|
This looks great! Thanks! Can you add a chancelog entry? |
manuel-em
force-pushed
the
6576-prefersReducedMotion-padding
branch
from
4ed5919 to
f6e3eb2
Compare
|
Changelog entry added. Thanks for the review. |
HarelM
approved these changes
Oct 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On a flyTo call with a padding option, if the user has activated the browser prefers-reduced-motion, a jumpTo is call with some options picks to build a CameraOptions and the padding is lost. This change picks padding too and build a JumpToOptions instead.