Skip to content

Define how much to slice and how much to scale #6617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: 2507-overzoom-geojson-vt
Choose a base branch
from
Open

Define how much to slice and how much to scale #6617

wants to merge 3 commits into from
+21 −26

Conversation

@HarelM
Copy link
Collaborator

@HarelM HarelM commented Oct 26, 2025

Launch Checklist

This is a PR to showcase a different approach to overzoom with more control on when to slice and when to scale.

@HarelM
Copy link
Collaborator Author

HarelM commented Oct 26, 2025

CC: @wayofthefuture

@HarelM HarelM mentioned this pull request Oct 26, 2025
Open
5 tasks
@codecov
Copy link

codecov bot commented Oct 26, 2025 •
edited
Loading

❌ 48 Tests Failed:

Tests completed Failed Passed Skipped
3018 48 2970 0
View the top 3 failed test(s) by shortest run time 
tests/debug/tile-raster::tests/debug/tile-raster
Stack Traces | 0s run time 
No failure message available
tests/line-dasharray/overscaled::tests/line-dasharray/overscaled
Stack Traces | 0s run time 
No failure message available
tests/line-dasharray/slant::tests/line-dasharray/slant
Stack Traces | 0s run time 
No failure message available
tests/line-pattern/pitch::tests/line-pattern/pitch
Stack Traces | 0s run time 
No failure message available
tests/symbol-placement/line-center-upperright::tests/symbol-placement/line-center-upperright
Stack Traces | 0s run time 
No failure message available
tests/symbol-placement/line-center::tests/symbol-placement/line-center
Stack Traces | 0s run time 
No failure message available
tests/symbol-placement/line-overlap::tests/symbol-placement/line-overlap
Stack Traces | 0s run time 
No failure message available
tests/symbol-placement/line-overscaled-debug::tests/symbol-placement/line-overscaled-debug
Stack Traces | 0s run time 
No failure message available
tests/symbol-placement/line-overscaled::tests/symbol-placement/line-overscaled
Stack Traces | 0s run time 
No failure message available
tests/symbol-placement/point-polygon::tests/symbol-placement/point-polygon
Stack Traces | 0s run time 
No failure message available
tests/symbol-spacing/line-overscaled::tests/symbol-spacing/line-overscaled
Stack Traces | 0s run time 
No failure message available
tests/text-pitch-alignment/auto-text-rotation-alignment-map::tests/text-pitch-alignment/auto-text-rotation-alignment-map
Stack Traces | 0s run time 
No failure message available
tests/text-pitch-alignment/auto-text-rotation-alignment-viewport-glyph::tests/text-pitch-alignment/auto-text-rotation-alignment-viewport-glyph
Stack Traces | 0s run time 
No failure message available
tests/text-pitch-alignment/auto-text-rotation-alignment-viewport::tests/text-pitch-alignment/auto-text-rotation-alignment-viewport
Stack Traces | 0s run time 
No failure message available
tests/text-pitch-alignment/map-text-rotation-alignment-map::tests/text-pitch-alignment/map-text-rotation-alignment-map
Stack Traces | 0s run time 
No failure message available
tests/text-pitch-alignment/map-text-rotation-alignment-viewport-debug::tests/text-pitch-alignment/map-text-rotation-alignment-viewport-debug
Stack Traces | 0s run time 
No failure message available
tests/text-pitch-alignment/map-text-rotation-alignment-viewport::tests/text-pitch-alignment/map-text-rotation-alignment-viewport
Stack Traces | 0s run time 
No failure message available
tests/text-pitch-alignment/viewport-overzoomed-single-glyph::tests/text-pitch-alignment/viewport-overzoomed-single-glyph
Stack Traces | 0s run time 
No failure message available
tests/text-pitch-alignment/viewport-text-rotation-alignment-map::tests/text-pitch-alignment/viewport-text-rotation-alignment-map
Stack Traces | 0s run time 
No failure message available
tests/text-pitch-alignment/viewport-text-rotation-alignment-viewport::tests/text-pitch-alignment/viewport-text-rotation-alignment-viewport
Stack Traces | 0s run time 
No failure message available
tests/text-pitch-scaling/line-half-roll::tests/text-pitch-scaling/line-half-roll
Stack Traces | 0s run time 
No failure message available
tests/text-pitch-scaling/line-half::tests/text-pitch-scaling/line-half
Stack Traces | 0s run time 
No failure message available
tests/text-variable-anchor-offset/all-anchors-text-allow-overlap::tests/text-variable-anchor-offset/all-anchors-text-allow-overlap
Stack Traces | 0s run time 
No failure message available
tests/text-variable-anchor/all-anchors-text-allow-overlap::tests/text-variable-anchor/all-anchors-text-allow-overlap
Stack Traces | 0s run time 
No failure message available
tests\debug\tile-raster::tests\debug\tile-raster
Stack Traces | 0s run time 
No failure message available
tests\line-dasharray\overscaled::tests\line-dasharray\overscaled
Stack Traces | 0s run time 
No failure message available
tests\line-dasharray\slant::tests\line-dasharray\slant
Stack Traces | 0s run time 
No failure message available
tests\line-pattern\pitch::tests\line-pattern\pitch
Stack Traces | 0s run time 
No failure message available
tests\symbol-placement\line-center-upperright::tests\symbol-placement\line-center-upperright
Stack Traces | 0s run time 
No failure message available
tests\symbol-placement\line-center::tests\symbol-placement\line-center
Stack Traces | 0s run time 
No failure message available
tests\symbol-placement\line-overlap::tests\symbol-placement\line-overlap
Stack Traces | 0s run time 
No failure message available
tests\symbol-placement\line-overscaled-debug::tests\symbol-placement\line-overscaled-debug
Stack Traces | 0s run time 
No failure message available
tests\symbol-placement\line-overscaled::tests\symbol-placement\line-overscaled
Stack Traces | 0s run time 
No failure message available
tests\symbol-placement\point-polygon::tests\symbol-placement\point-polygon
Stack Traces | 0s run time 
No failure message available
tests\symbol-spacing\line-overscaled::tests\symbol-spacing\line-overscaled
Stack Traces | 0s run time 
No failure message available
tests\text-pitch-alignment\auto-text-rotation-alignment-map::tests\text-pitch-alignment\auto-text-rotation-alignment-map
Stack Traces | 0s run time 
No failure message available
tests\text-pitch-alignment\auto-text-rotation-alignment-viewport-glyph::tests\text-pitch-alignment\auto-text-rotation-alignment-viewport-glyph
Stack Traces | 0s run time 
No failure message available
tests\text-pitch-alignment\auto-text-rotation-alignment-viewport::tests\text-pitch-alignment\auto-text-rotation-alignment-viewport
Stack Traces | 0s run time 
No failure message available
tests\text-pitch-alignment\map-text-rotation-alignment-map::tests\text-pitch-alignment\map-text-rotation-alignment-map
Stack Traces | 0s run time 
No failure message available
tests\text-pitch-alignment\map-text-rotation-alignment-viewport-debug::tests\text-pitch-alignment\map-text-rotation-alignment-viewport-debug
Stack Traces | 0s run time 
No failure message available
tests\text-pitch-alignment\map-text-rotation-alignment-viewport::tests\text-pitch-alignment\map-text-rotation-alignment-viewport
Stack Traces | 0s run time 
No failure message available
tests\text-pitch-alignment\viewport-overzoomed-single-glyph::tests\text-pitch-alignment\viewport-overzoomed-single-glyph
Stack Traces | 0s run time 
No failure message available
tests\text-pitch-alignment\viewport-text-rotation-alignment-map::tests\text-pitch-alignment\viewport-text-rotation-alignment-map
Stack Traces | 0s run time 
No failure message available
tests\text-pitch-alignment\viewport-text-rotation-alignment-viewport::tests\text-pitch-alignment\viewport-text-rotation-alignment-viewport
Stack Traces | 0s run time 
No failure message available
tests\text-pitch-scaling\line-half-roll::tests\text-pitch-scaling\line-half-roll
Stack Traces | 0s run time 
No failure message available
tests\text-pitch-scaling\line-half::tests\text-pitch-scaling\line-half
Stack Traces | 0s run time 
No failure message available
tests\text-variable-anchor-offset\all-anchors-text-allow-overlap::tests\text-variable-anchor-offset\all-anchors-text-allow-overlap
Stack Traces | 0s run time 
No failure message available
tests\text-variable-anchor\all-anchors-text-allow-overlap::tests\text-variable-anchor\all-anchors-text-allow-overlap
Stack Traces | 0s run time 
No failure message available

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@HarelM HarelM mentioned this pull request Oct 27, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@HarelM