Skip to content

Conversation

@intmainvoid
Copy link
Collaborator

@intmainvoid intmainvoid commented Aug 29, 2021

Version v1.0.0-alpha.4 of data-api-local has been published to npm already (as that is all I have permission to publish). This is essentially useless however without releasing a new version of data-api-local-serverless which depends on the exact version of data-api-local at v1.0.0-alpha.2.

This PR proposes that we change the version of all packages to the tagged version in this repo (v.1.0.0-alpha.4). This will ensure that the tags in the git repo match the tags in the package.json file of each package.

Additionally, these packages should be published soon after as:

  • they contain changes currently in master (such as using compatible-versioned dependencies instead of exact) that pass tests but not yet published. They also work well in at least one significant project I know of.
  • v1.0.0-alpha.4 of data-api-local can be used from data-api-local-serverless.

@codecov
Copy link

codecov bot commented Aug 29, 2021

Codecov Report

Merging #51 (e8a6963) into master (754497e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #51   +/-   ##
=======================================
  Coverage   96.98%   96.98%           
=======================================
  Files          21       21           
  Lines         763      763           
  Branches      162      162           
=======================================
  Hits          740      740           
  Misses         23       23           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 754497e...e8a6963. Read the comment docs.

@marcgreenstock
Copy link
Owner

Hi @intmainvoid, sorry I had not addressed this until now.

Considering you have contributed a significant amount to this project, are you interested in being a maintainer?

@intmainvoid
Copy link
Collaborator Author

@marcgreenstock

Considering you have contributed a significant amount to this project, are you interested in being a maintainer?

Yes pls. That would make life easier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants