Remediate phase 1 critique observations #4
+1,712
−396
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit refactors the context API to use dictionaries for internal storage, improving testability and simplifying the data flow. It also introduces a new `/test` endpoint for controlling service availability and clearing data, further enhancing the testing capabilities. Co-authored-by: mjpolanco <[email protected]>
|
Cursor Agent can help with this pull request. Just |
marcospolanco
force-pushed
the
cursor/remediate-phase-1-critique-observations-a571
branch
from
51f3412 to
e1fdf81
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remediate observations from
PHASE1_critique.mdby fixing deprecations, improving exception handling, and enhancing test control endpoint flexibility.The changes address specific observations from the critique, including updating
datetime.utcnowtodatetime.now(timezone.utc)and.dict()to.model_dump(mode="json"). Exception handling is improved by explicitly re-raisingHTTPExceptionto preserve original status codes. New test control endpoints are introduced to manage mock service states and clear data, now correctly accepting JSON bodies as required by the critique. API endpoint signatures in thecontextmodule are also made more flexible to better align with the test suite's expectations for request and response structures.